[BugFix] Add missing streamvbyte link dependency for SerdeCore#72365
Merged
Conversation
Signed-off-by: wangruin <913474924@qq.com>
eceec4e to
91946ee
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
kevincai
approved these changes
Apr 30, 2026
Contributor
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
stdpain
approved these changes
Apr 30, 2026
robd003
pushed a commit
to robd003/starrocks
that referenced
this pull request
May 6, 2026
…ocks#72365) Signed-off-by: wangruin <913474924@qq.com>
xiangguangyxg
pushed a commit
to xiangguangyxg/starrocks
that referenced
this pull request
May 7, 2026
…ocks#72365) Signed-off-by: wangruin <913474924@qq.com> Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
PR #72303 extracted
column_array_serde.cppinto a newSerdeCorelibrary but did not declare its dependency onstreamvbyte.column_array_serde.cppcallsstreamvbyte_encode,streamvbyte_decode,streamvbyte_delta_encode, andstreamvbyte_delta_decode, which are provided by thestreamvbytethird-party library.This causes a link failure when building with GNU
goldlinker (used on CentOS with glibc < 2.29):The CI (Ubuntu,
lldlinker) passes becauselldresolves symbols globally across all--start-group/--end-groupboundaries, whilegoldstrictly respects group scoping for transitive dependencies placed outside the group.What I'm doing:
Add
streamvbytetoSerdeCore'starget_link_librariesso the dependency is correctly declared regardless of linker.Introduced in #72303
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: