Skip to content

[BugFix] Add missing streamvbyte link dependency for SerdeCore#72365

Merged
stdpain merged 1 commit into
StarRocks:mainfrom
wangruin:fix/serde-core-link-streamvbyte
Apr 30, 2026
Merged

[BugFix] Add missing streamvbyte link dependency for SerdeCore#72365
stdpain merged 1 commit into
StarRocks:mainfrom
wangruin:fix/serde-core-link-streamvbyte

Conversation

@wangruin

@wangruin wangruin commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Why I'm doing:

PR #72303 extracted column_array_serde.cpp into a new SerdeCore library but did not declare its dependency on streamvbyte. column_array_serde.cpp calls streamvbyte_encode, streamvbyte_decode, streamvbyte_delta_encode, and streamvbyte_delta_decode, which are provided by the streamvbyte third-party library.

This causes a link failure when building with GNU gold linker (used on CentOS with glibc < 2.29):

be/src/serde/column_array_serde.cpp:116: error: undefined reference to 'streamvbyte_encode'
be/src/serde/column_array_serde.cpp:112: error: undefined reference to 'streamvbyte_delta_encode'
be/src/serde/column_array_serde.cpp:157: error: undefined reference to 'streamvbyte_delta_decode'
be/src/serde/column_array_serde.cpp:159: error: undefined reference to 'streamvbyte_decode'

The CI (Ubuntu, lld linker) passes because lld resolves symbols globally across all --start-group/--end-group boundaries, while gold strictly respects group scoping for transitive dependencies placed outside the group.

What I'm doing:

Add streamvbyte to SerdeCore's target_link_libraries so the dependency is correctly declared regardless of linker.

Introduced in #72303

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5
    • 3.4

@github-actions github-actions Bot requested a review from kevincai April 30, 2026 02:21
Signed-off-by: wangruin <913474924@qq.com>
@wangruin wangruin force-pushed the fix/serde-core-link-streamvbyte branch from eceec4e to 91946ee Compare April 30, 2026 02:26
@github-actions github-actions Bot added the 4.1 label Apr 30, 2026
@CelerData-Reviewer

Copy link
Copy Markdown

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions github-actions Bot removed the 4.1 label Apr 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions

Copy link
Copy Markdown
Contributor

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions

Copy link
Copy Markdown
Contributor

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@stdpain stdpain merged commit 5387efb into StarRocks:main Apr 30, 2026
155 of 158 checks passed
robd003 pushed a commit to robd003/starrocks that referenced this pull request May 6, 2026
xiangguangyxg pushed a commit to xiangguangyxg/starrocks that referenced this pull request May 7, 2026
…ocks#72365)

Signed-off-by: wangruin <913474924@qq.com>
Signed-off-by: xiangguangyxg <xiangguangyxg@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants