[WIP]Support Lance Connector#74690
Open
caneGuy wants to merge 2 commits into
Open
Conversation
Port the Lance integration from the supportAiTable branch onto main and rename the former "AI table" surface to Lance: - LanceTable catalog type + LanceTableFactory, exposed as ENGINE=LANCE - lance-reader JNI extension (lance-core 0.31.0, Arrow -> SR type mapping) - LanceScanNode + Logical/PhysicalLanceScanOperator; column prune, predicate push down, and KNN vector-search push down (cosine_similarity / l2_distance) via the vector rewrite rule set - BE LanceTableDescriptor + create_lance_jni_scanner - thrift TLanceTable / TLanceQuery and THdfsScanRange lance fields Storage credentials/endpoint are sourced from table PROPERTIES (aws.s3.access_key / secret_key / endpoint, plus lance.option.* passthrough) and plumbed FE -> THdfsScanRange.lance_storage_options -> JNI scanner. No credentials are hardcoded anywhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Enable `CREATE EXTERNAL CATALOG x PROPERTIES("type"="lance", ...)` on top of
the existing ENGINE=LANCE table support, so Lance datasets can be queried via
a catalog instead of declaring each table by hand.
- LanceConnector / LanceMetadata implementing Connector / ConnectorMetadata
- Register "lance" in ConnectorType (enum + SUPPORT_TYPE_SET); CatalogAnalyzer
validates it automatically
- LanceMetadata.getTable derives the dataset uri from
lance.catalog.warehouse/<db>/<table>.lance, opens the dataset to infer the
schema (Arrow -> StarRocks type mapping, FixedSizeList<float> -> ARRAY<FLOAT>
for vector columns), and returns a LanceTable carrying catalog/db identity
- Storage credentials/endpoint flow from the catalog PROPERTIES into each
table's properties (aws.s3.* / lance.option.*) and reuse the existing scan
path; no credentials are hardcoded
- Scan planning, column prune, predicate and KNN push down are reused unchanged
Note: listDbNames/listTableNames are not implemented (Lance has no central
namespace to enumerate); query a known db.table directly.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
caneGuy seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
sevev
approved these changes
Jun 12, 2026
sevev
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: