[Refactor] Move predicate tree into storage primitive module#74910
Merged
Conversation
Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Contributor
[Java-Extensions Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[FE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
Contributor
[BE Incremental Coverage Report]✅ pass : 331 / 359 (92.20%) file detail
|
sevev
added a commit
to sevev/starrocks
that referenced
this pull request
Jun 22, 2026
The storage predicate headers were relocated to storage/primitive/ (StarRocks#74910, StarRocks#74933) and runtime_range_pruner to compute_env/ on main. After rebasing this branch onto current main, vector_search_test.cpp still included the old paths and failed to compile. Repoint the includes to their new locations; no behavior change. Signed-off-by: sevev <qiangzh95@gmail.com>
OliLay
pushed a commit
to OliLay/starrocks
that referenced
this pull request
Jun 30, 2026
…ks#74910) Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai> Signed-off-by: Oliver Layer <o.layer@celonis.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm doing:
What I'm doing:
Fixes #issue
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: