Skip to content

[Refactor] Move scan range filter primitives to storage primitive#74912

Merged
alvin-phoenix-ai merged 1 commit into
StarRocks:mainfrom
alvin-phoenix-ai:opt-format-11
Jun 16, 2026
Merged

[Refactor] Move scan range filter primitives to storage primitive#74912
alvin-phoenix-ai merged 1 commit into
StarRocks:mainfrom
alvin-phoenix-ai:opt-format-11

Conversation

@alvin-phoenix-ai

Copy link
Copy Markdown
Contributor

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
    • This pr needs auto generate documentation
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 4.1
    • 4.0
    • 3.5

Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
@CelerData-Reviewer

Copy link
Copy Markdown

@codex review

@github-actions github-actions Bot requested review from stdpain and trueeyu June 16, 2026 22:04
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: f2ebe2dae5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-actions

Copy link
Copy Markdown
Contributor

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

@github-actions

Copy link
Copy Markdown
Contributor

[FE Incremental Coverage Report]

pass : 0 / 0 (0%)

@alvin-phoenix-ai alvin-phoenix-ai merged commit e76fddc into StarRocks:main Jun 16, 2026
51 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

[BE Incremental Coverage Report]

fail : 330 / 486 (67.90%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 be/src/storage/primitive/column_and_predicate.cpp 3 40 07.50% [23, 24, 27, 28, 29, 31, 34, 35, 36, 37, 38, 39, 41, 44, 45, 46, 47, 48, 49, 51, 53, 54, 55, 57, 58, 59, 60, 62, 73, 75, 76, 77, 78, 79, 80, 82, 83]
🔵 be/src/storage/primitive/column_and_predicate.h 4 10 40.00% [21, 40, 43, 44, 45, 46]
🔵 be/src/storage/primitive/column_or_predicate.h 4 10 40.00% [23, 45, 49, 51, 54, 57]
🔵 be/src/storage/primitive/column_or_predicate.cpp 17 42 40.48% [24, 25, 39, 40, 41, 43, 61, 63, 64, 65, 66, 67, 68, 70, 71, 74, 75, 76, 77, 78, 79, 81, 83, 84, 85]
🔵 be/src/storage/predicate_parser.cpp 3 5 60.00% [95, 96]
🔵 be/src/storage/primitive/column_value_range.cpp 219 282 77.66% [42, 43, 44, 45, 47, 57, 58, 59, 73, 74, 75, 80, 83, 86, 89, 92, 93, 94, 95, 96, 97, 98, 99, 100, 123, 196, 201, 203, 204, 205, 207, 208, 209, 212, 213, 219, 220, 221, 223, 237, 238, 242, 275, 281, 298, 299, 327, 350, 373, 374, 385, 396, 431, 446, 447, 448, 449, 450, 451, 452, 453, 454, 455]
🔵 be/src/storage/primitive/filter_op.h 27 35 77.14% [54, 55, 56, 59, 76, 77, 78, 80]
🔵 be/src/storage/primitive/value_cast.h 22 28 78.57% [63, 66, 68, 76, 84, 90]
🔵 be/src/storage/primitive/filter_condition.h 17 19 89.47% [46, 48]
🔵 be/src/storage/primitive/column_value_range.h 11 12 91.67% [86]
🔵 be/src/storage/primitive/predicate_parser.h 2 2 100.00% []
🔵 be/src/exec/olap_common.cpp 1 1 100.00% []

OliLay pushed a commit to OliLay/starrocks that referenced this pull request Jun 30, 2026
…arRocks#74912)

Signed-off-by: alvin-phoenix-ai <alvin.zhao@phoenixdata.ai>
Signed-off-by: Oliver Layer <o.layer@celonis.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants