[BugFix] Fix ASAN crash for BOOLEAN nested in Avro complex-type columns by banmoy · Pull Request #76041 · StarRocks/starrocks

banmoy · 2026-07-08T11:09:03Z

Why I'm doing:

Fix the daily ASAN crash reported in StarRocks/StarRocksTest#11522:

be/src/gutil/casts.h:78: To down_cast(From*) [with To = FixedLengthColumn<signed char>*; ...]:
Assertion `f == __null || dynamic_cast<To>(f) != __null' failed.

It aborts BE when an Avro routine load targets a native complex-type column (STRUCT/MAP/ARRAY) that contains a BOOLEAN field/element/value.

What I'm doing:

BooleanColumn is FixedLengthColumn<uint8_t>, but the nested (non-adaptive) add_nullable_column in be/src/formats/avro/nullable_column.cpp dispatched TYPE_BOOLEAN through add_nullable_numeric_column<int8_t>. add_numeric_column<int8_t> then down_casts the uint8 column to FixedLengthColumn<int8_t>*, which trips the dynamic_cast assert under ASAN/DEBUG.

The adaptive path (add_adpative_nullable_column, used for top-level columns) already dispatched TYPE_BOOLEAN through the correct <uint8_t> — which is why only complex types crashed and a plain top-level BOOLEAN column was fine. The fix dispatches the nested path through <uint8_t> too. add_numeric_column<uint8_t> is already explicitly instantiated, so no other change is needed.

Added regression test AvroScannerTest.test_struct_with_boolean; the full AvroScannerTest suite (26 tests) passes on a clean ASAN build.

Notes:

The crash-reachable STRUCT/MAP paths were made reachable by [Enhancement] Support native MAP/STRUCT target columns for Avro routine load #74901 (main only). The nested ARRAY path carries the same latent mismatch since [Feature] Parse avro data directly #19866.
In opt builds the assert is compiled out and int8_t/uint8_t are layout-identical, so for valid boolean data this is an ASAN/DEBUG crash rather than a release data-correctness issue.

Fixes StarRocks/StarRocksTest#11522

What type of PR is this:

Does this PR entail a change in behavior?

Yes, this PR will result in a change in behavior.
No, this PR will not result in a change in behavior.

Checklist:

I have added test cases for my bug fix or my new feature
This pr needs user documentation (for new or modified features or behaviors)
- I have added documentation for my new feature or new function
- This pr needs auto generate documentation
This is a backport pr

Bugfix cherry-pick branch check:

I have checked the version labels which the pr will be auto-backported to the target branch
- 4.1
- 4.0
- 3.5

BooleanColumn is FixedLengthColumn<uint8_t>, but the nested (non-adaptive) add_nullable_column dispatched TYPE_BOOLEAN through add_nullable_numeric_column<int8_t>. add_numeric_column then down_cast the uint8 column to FixedLengthColumn<int8_t>*, tripping the dynamic_cast assert (gutil/casts.h) under ASAN/DEBUG whenever a BOOLEAN is nested inside a native STRUCT/MAP/ARRAY target column of an Avro routine load (StarRocksTest#11522). The adaptive path (add_adpative_nullable_column, used for top-level columns) already dispatched TYPE_BOOLEAN through <uint8_t>, which is why only complex types crashed. Dispatch the nested path through <uint8_t> as well. Add regression test AvroScannerTest.test_struct_with_boolean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GN8hHLLGz7o25mvSJhwqXr

github-actions · 2026-07-08T11:09:59Z

⚠️ coverage incomplete — code_kb context-base tool is unavailable in this session; module risk NOT assessed.


This is not an "all clear" — it's a tooling/access gap. To actually run this review I need the `context-base` MCP server connected (providing `list_collections`/`context_get` for `contextbase="code_kb"`). Can you confirm that MCP server is configured for this environment, or point me to how it's normally invoked here (e.g., a different tool name)?

CelerData-Reviewer · 2026-07-08T11:10:03Z

@codex review

chatgpt-codex-connector · 2026-07-08T11:12:14Z

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 8bce3df3b9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…ibility test_struct_with_boolean depends on native STRUCT target support (PR StarRocks#74901, main only), so it cannot cherry-pick to release branches that lack it. Replace it with test_array_with_boolean, which drives the same add_nullable_column TYPE_BOOLEAN dispatch (the fixed line) and whose ARRAY path is present on all release branches. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GN8hHLLGz7o25mvSJhwqXr

github-actions · 2026-07-08T12:38:59Z

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-07-08T12:39:01Z

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

github-actions · 2026-07-08T12:58:08Z

[BE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	be/src/formats/avro/nullable_column.cpp	1	1	100.00%	[]

github-actions · 2026-07-09T02:11:30Z

@Mergifyio backport branch-4.1

github-actions · 2026-07-09T02:11:31Z

@Mergifyio backport branch-4.0

mergify · 2026-07-09T02:11:38Z

backport branch-4.1

✅ Backports have been created

Details

#76064 [BugFix] Fix ASAN crash for BOOLEAN nested in Avro complex-type columns (backport #76041) has been created for branch branch-4.1

mergify · 2026-07-09T02:11:39Z

backport branch-4.0

✅ Backports have been created

Details

#76065 [BugFix] Fix ASAN crash for BOOLEAN nested in Avro complex-type columns (backport #76041) has been created for branch branch-4.0 but encountered conflicts

Cherry-pick of bed4395 has failed:

On branch mergify/bp/branch-4.0/pr-76041
Your branch is up to date with 'origin/branch-4.0'.

You are currently cherry-picking commit bed4395814.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   be/src/formats/avro/nullable_column.cpp
	both modified:   be/test/exec/avro_scanner_test.cpp

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

…ns (backport #76041) (#76064) Co-authored-by: PengFei Li <lpengfei2016@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

github-actions Bot added 4.0 4.1 labels Jul 8, 2026

mergify Bot assigned banmoy Jul 8, 2026

github-actions Bot requested review from ZiheLiu and gengjun-git July 8, 2026 11:12

kevincai approved these changes Jul 8, 2026

View reviewed changes

wyb approved these changes Jul 9, 2026

View reviewed changes

wyb merged commit bed4395 into StarRocks:main Jul 9, 2026
65 of 66 checks passed

github-actions Bot removed 4.1 4.0 labels Jul 9, 2026

This was referenced Jul 9, 2026

[BugFix] Fix ASAN crash for BOOLEAN nested in Avro complex-type columns (backport #76041) #76064

Merged

[BugFix] Fix ASAN crash for BOOLEAN nested in Avro complex-type columns (backport #76041) #76065

Closed

banmoy mentioned this pull request Jul 9, 2026

[BugFix] Fix ASAN crash for BOOLEAN nested in Avro complex-type columns (backport #76041) #76066

Closed

18 tasks

github-actions Bot added the 4.1-merged label Jul 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[BugFix] Fix ASAN crash for BOOLEAN nested in Avro complex-type columns#76041

[BugFix] Fix ASAN crash for BOOLEAN nested in Avro complex-type columns#76041
wyb merged 2 commits into
StarRocks:mainfrom
banmoy:fix_11522

banmoy commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

CelerData-Reviewer commented Jul 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

mergify Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

mergify Bot commented Jul 9, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

banmoy commented Jul 8, 2026

Why I'm doing:

What I'm doing:

What type of PR is this:

Checklist:

Bugfix cherry-pick branch check:

Uh oh!

github-actions Bot commented Jul 8, 2026

Uh oh!

CelerData-Reviewer commented Jul 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Jul 8, 2026

Uh oh!

github-actions Bot commented Jul 8, 2026

[Java-Extensions Incremental Coverage Report]

Uh oh!

github-actions Bot commented Jul 8, 2026

[FE Incremental Coverage Report]

Uh oh!

github-actions Bot commented Jul 8, 2026

[BE Incremental Coverage Report]

file detail

Uh oh!

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

github-actions Bot commented Jul 9, 2026

Uh oh!

mergify Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

mergify Bot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mergify Bot commented Jul 9, 2026 •

edited

Loading

mergify Bot commented Jul 9, 2026 •

edited

Loading