Large Boiler Rework leftovers - #616
Open
trulyno wants to merge 1 commit into
Open
Conversation
✅ KubeJS Scripts Lint & Format ReviewAll scripts pass formatting and lint checks. Nice work! |
n1xx1
reviewed
Aug 22, 2026
| ingredient.add('amount', amount); | ||
| ingredient.add('value', { tag: tag }); | ||
|
|
||
| return FluidIngredientJS.of(ingredient); |
Contributor
There was a problem hiding this comment.
Doesn't .of({ amount: amount, value: { tag: tag }) work? If it's a typecheck problem, change FluidIngredientJS.of method argument from JSONObject to $wrapped<JSONObject> or just add another overload for the correctly typed object I guess
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the syseteams and steam turbines to use the new steam fluids added in core mod.
Made sure the change is backwards compatible with the systeams steam fluids.