Skip to content

fix(cli): accept auto/mps devices in index build, with CI-safe test#109

Closed
aafaq-rashid-comprinno wants to merge 1 commit into
StarTrail-org:mainfrom
aafaq-rashid-comprinno:fix/ci-index-build-test
Closed

fix(cli): accept auto/mps devices in index build, with CI-safe test#109
aafaq-rashid-comprinno wants to merge 1 commit into
StarTrail-org:mainfrom
aafaq-rashid-comprinno:fix/ci-index-build-test

Conversation

@aafaq-rashid-comprinno

Copy link
Copy Markdown
Contributor

Problem

pixelrag index build --device auto fails because argparse only allows cpu and cuda. PR #73 fixed the choices but its test fails in CI because pixelrag index build --help imports config.pyyaml which isn't installed in core-only CI.

Fix

  1. Add auto, mps to --device choices
  2. Test gracefully skips when the index stage isn't installed:
    if r.returncode != 0 and "not installed" in (r.stdout + r.stderr):
        pytest.skip("index stage not installed")

Supersedes #73 (same feature fix + working CI).

@vercel

vercel Bot commented Jun 28, 2026

Copy link
Copy Markdown

@aafaq-rashid-comprinno is attempting to deploy a commit to the andylizf's projects Team on Vercel.

A member of the Team first needs to authorize it.

Adds 'auto' and 'mps' to --device choices for pixelrag index build.
The test gracefully skips in CI where the index stage (pyyaml) isn't
installed, preventing the ModuleNotFoundError that broke PR StarTrail-org#73.

Supersedes StarTrail-org#73 (same fix + CI-compatible test).
@andylizf

Copy link
Copy Markdown
Contributor

Thanks @aafaq-rashid-comprinno — superseded by #73, which makes the same --device auto/mps fix. The CI failure this PR worked around with a test skip is now fixed at the root in #118 (the light deps tqdm/pyyaml/numpy were mis-filed behind the torch extra), so #73's straightforward test passes without any skip. Really appreciate the fix and the CI diagnosis that led to the root-cause cleanup.

@andylizf andylizf closed this Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants