fix: correct torch_dtype kwarg, help text default, and CLI backend choices#123
Open
fix2015 wants to merge 1 commit into
Open
fix: correct torch_dtype kwarg, help text default, and CLI backend choices#123fix2015 wants to merge 1 commit into
fix2015 wants to merge 1 commit into
Conversation
|
@fix2015 is attempting to deploy a commit to the andylizf's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serve/src/pixelrag_serve/api.py: Fixeddtype=dtype→torch_dtype=dtypeinQwen3VLForConditionalGeneration.from_pretrained()call, matching every other call site in the codebase.index/src/pixelrag_index/monitor.py: Fixed--validate-max-fail-pcthelp string that incorrectly stated(default: 10.0)when the actual default is5.0.render/src/pixelrag_render/render.py: Removed"playwright"from--backendargparse choices since only the CDP backend is implemented.Test plan
torch_dtypeis the correct kwarg used by all otherfrom_pretrainedcalls in the codebasedefault=5.0matches the corrected help text