docs(test): document and expand coverage for configurable table-skeleton rows (#609) - #1142
Open
apatafamilycompound123-ops wants to merge 1 commit into
Conversation
Contributor
|
@apatafamilycompound123-ops is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Description
Completes the acceptance criteria for #609 — "Add a configurable row-count prop to
components/ui/table-skeleton.tsx".TableSkeletonandTransactionTableSkeletonalready expose arowsprop (default6). This PR rounds out that work with clear component documentation and expanded test coverage for therowsprop so the placeholder can match real loaded-content row counts (e.g. a paginated transactions table vs. a short notifications list).🧩 Changes
rows(andcolumns/showHeader) props onTableSkeletonandTransactionTableSkeleton.components/ui/table-skeleton.test.tsx:rows={10}) for both components.rows={0}for both components.rowsprop.✅ Acceptance criteria
rowsprop controls rendered skeleton row count.🧪 Verification
npx vitest run components/ui/table-skeleton.test.tsx— 19 tests passing.🔒 Security notes
N/A — presentational component only.
🔗 Related
Closes #609