Skip to content

docs(test): document and expand coverage for configurable table-skeleton rows (#609) - #1142

Open
apatafamilycompound123-ops wants to merge 1 commit into
Stellopay:mainfrom
apatafamilycompound123-ops:feat/configurable-table-skeleton-rows
Open

docs(test): document and expand coverage for configurable table-skeleton rows (#609)#1142
apatafamilycompound123-ops wants to merge 1 commit into
Stellopay:mainfrom
apatafamilycompound123-ops:feat/configurable-table-skeleton-rows

Conversation

@apatafamilycompound123-ops

Copy link
Copy Markdown

📌 Description

Completes the acceptance criteria for #609 — "Add a configurable row-count prop to components/ui/table-skeleton.tsx".

TableSkeleton and TransactionTableSkeleton already expose a rows prop (default 6). This PR rounds out that work with clear component documentation and expanded test coverage for the rows prop so the placeholder can match real loaded-content row counts (e.g. a paginated transactions table vs. a short notifications list).

🧩 Changes

  • Documentation: added JSDoc + usage examples for the rows (and columns / showHeader) props on TableSkeleton and TransactionTableSkeleton.
  • Tests added in components/ui/table-skeleton.test.tsx:
    • Custom larger row count (rows={10}) for both components.
    • Zero body rows when rows={0} for both components.
    • Header row is unaffected by the rows prop.

✅ Acceptance criteria

  • rows prop controls rendered skeleton row count.
  • Default behavior unchanged for existing call sites that don't pass the prop.
  • Test covers a custom row count.

🧪 Verification

npx vitest run components/ui/table-skeleton.test.tsx — 19 tests passing.

🔒 Security notes

N/A — presentational component only.

🔗 Related

Closes #609

@vercel

vercel Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

@apatafamilycompound123-ops is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a configurable row-count prop to components/ui/table-skeleton.tsx

1 participant