test: add dir="rtl" Playwright smoke test for dashboard shell (Closes #821) - #1149
Open
waterWang wants to merge 1 commit into
Open
test: add dir="rtl" Playwright smoke test for dashboard shell (Closes #821)#1149waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Contributor
|
@waterWang is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #821 — add a Playwright smoke test that forces
dir="rtl"on the root<html>element and loads the/dashboardroute.What it checks
document.documentElement.scrollWidth <= clientWidth. When RTL breaks a layout, the document grows wider than the viewport and a horizontal scrollbar appears.getBoundingClientRect()extends beyond the viewport width (the classic RTL clipping signal). Hidden / off-screen / zero-size elements are skipped to avoid false positives.__screenshots__/rtl-dashboard.pngfor manual visual review by the team.Why this helps
RTL readiness currently has zero automated coverage — regressions in overflow, misaligned icons, or clipped text would only be caught manually. This test gives us a deterministic guard ahead of eventual locale support.
Test file
e2e/rtl-dashboard.spec.ts— new Playwright spec (91 lines)How to run
npx playwright test e2e/rtl-dashboard.spec.tsThe test uses
page.addInitScriptto setdir="rtl"before the app boots, so the assertion runs against a genuinely RTL document.