feat: add slide-in mobile menu with focus-trap to landing nav bar (Closes #876) - #1150
Open
waterWang wants to merge 1 commit into
Open
feat: add slide-in mobile menu with focus-trap to landing nav bar (Closes #876)#1150waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
Contributor
|
@waterWang is attempting to deploy a commit to the Jagadeesh B's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a slide-in mobile menu with focus-trap to
components/landing/landing-page-nav-bar.tsxfor viewports below themdbreakpoint (768px).Previously the landing nav bar's mobile panel was a basic centered dropdown that overflowed/wrapped awkwardly under 768px. This replaces it with a proper right-side slide-in drawer.
Changes
mdbreakpoint, with a dimmed backdrop overlayusePathnamechangerole="dialog",aria-modal="true",aria-expanded,aria-controls, dynamicaria-labelon the togglefocus-visible:ringon all interactive elements for WCAG 2.1 AAFiles changed
components/landing/landing-page-nav-bar.tsx— slide-in drawer with focus managementcomponents/landing/landing-page-nav-bar.test.tsx— new tests covering open/close, focus trap, Escape, route change, outside click, and scroll lockTests
Added
landing-page-nav-bar.test.tsxwith 13 tests covering:aria-expandedstaterole="dialog"/aria-modal="true"attributesAccessibility
WCAG 2.1 AA: keyboard navigable, focus trap, focus return, visible focus rings, ARIA dialog semantics, and
aria-expanded/aria-controlson the trigger.Closes #876