refactor(docker): consolidate JVM options and improve dynamic memory computation by balazs-szucs · Pull Request #5933 · Stirling-Tools/Stirling-PDF

balazs-szucs · 2026-03-13T16:03:10Z

Closes: #5866

Description of Changes

Checklist

General

I have read the Contribution Guidelines
I have read the Stirling-PDF Developer Guide (if applicable)
I have read the How to add new languages to Stirling-PDF (if applicable)
I have performed a self-review of my own code
My changes generate no new warnings

Documentation

I have updated relevant docs on Stirling-PDF's doc repo (if functionality has heavily changed)
I have read the section Add New Translation Tags (for new translation tags only)

Translations (if applicable)

I ran scripts/counter_translation.py

UI Changes (if applicable)

Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

I have tested my changes locally. Refer to the Testing Guide for more details.

…computation Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

Copilot

Pull request overview

Refactors the container startup/JVM configuration to consolidate JVM option selection into a single _JVM_OPTS source and adjusts dynamic JVM memory percentage computation in init-without-ocr.sh.

Changes:

Simplified dynamic memory computation (removed profile-based branches; adjusted Initial/Max RAM % for mid/large containers).
Consolidated JVM option selection to JAVA_BASE_OPTS > _JVM_OPTS > fallback defaults, and added dynamic ConcGCThreads sizing based on CPU count.
Updated embedded Docker images to set a single _JVM_OPTS (Shenandoah generational) instead of balanced/performance profiles.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

File	Description
scripts/init-without-ocr.sh	Removes profile-based selection, tweaks memory sizing, adds CPU-based `ConcGCThreads`, consolidates JVM option sourcing.
docker/embedded/Dockerfile.ultra-lite	Replaces profile env vars with single `_JVM_OPTS` default.
docker/embedded/Dockerfile.fat	Replaces profile env vars with single `_JVM_OPTS` default (currently has a malformed flag string).
docker/embedded/Dockerfile	Replaces profile env vars with single `_JVM_OPTS` default.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

stirlingbot · 2026-03-14T13:29:16Z

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://23.22.230.180:5933
Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

…point Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

balazs-szucs · 2026-03-15T12:30:23Z

/deploypr

stirlingbot · 2026-03-15T12:42:18Z

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://23.22.230.180:5933
Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

stirlingbot · 2026-03-15T12:53:11Z

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://23.22.230.180:5933
Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

…ettings for virtual threads Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

balazs-szucs · 2026-03-15T14:38:19Z

/deploypr

stirlingbot · 2026-03-15T14:50:25Z

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://23.22.230.180:5933
Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

…rary file detection test

…t snapshot checks again...

balazs-szucs · 2026-06-02T18:34:04Z

/deploypr

balazs-szucs · 2026-06-02T19:57:09Z

/deploypr

balazs-szucs · 2026-06-11T18:06:25Z

/deploypr

stirlingbot · 2026-06-11T18:19:37Z

🚀 PR Test Deployment

Your PR has been deployed for testing!

🔗 Test URL: http://54.175.155.236:5933
Security Disabled

This deployment will be automatically cleaned up when the PR is closed.

Frooodle

T

…le updates for remote-only configurations

…init script

refactor(docker): consolidate JVM options and improve dynamic memory …

89de2bd

…computation Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

balazs-szucs requested review from ConnorYoh, Frooodle, Ludy87 and jbrunton96 as code owners March 13, 2026 16:03

Copilot AI review requested due to automatic review settings March 13, 2026 16:03

Merge branch 'main' into docker-stuff

e582868

stirlingbot Bot added Docker Pull requests that update Docker code refactor Code changes that neither fix a bug nor add a feature labels Mar 13, 2026

Copilot started reviewing on behalf of balazs-szucs March 13, 2026 16:03 View session

Frooodle reviewed Mar 13, 2026

View reviewed changes

Comment thread docker/embedded/Dockerfile.fat Outdated

Copilot AI reviewed Mar 13, 2026

View reviewed changes

Comment thread scripts/init-without-ocr.sh

Comment thread scripts/init-without-ocr.sh

Comment thread docker/embedded/Dockerfile.fat Outdated

Comment thread scripts/init-without-ocr.sh

Comment thread scripts/init-without-ocr.sh

fix(docker): correct JVM options for proper configuration

b956ba5

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

dosubot Bot added the size:M This PR changes 30-99 lines ignoring generated files. label Mar 13, 2026

balazs-szucs and others added 3 commits March 13, 2026 17:56

fix(docker): standardize JVM options across Dockerfiles and init script

2978fa0

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

fix(deps): update googleJavaFormatVersion to 1.35.0

4c7efc5

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

Merge branch 'main' into docker-stuff

36ea762

stirlingbot Bot added Gradle Pull requests that update Gradle code pr-deployed Pull request has been deployed to a test environment labels Mar 14, 2026

balazs-szucs marked this pull request as draft March 14, 2026 19:16

feat(docker): enhance JVM options and add security JAR setup in entry…

dad358b

…point Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

stirlingbot Bot added the Back End Issues related to back-end development label Mar 15, 2026

refactor(docker): simplify init scripts and enhance environment setup

f04cc7d

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

fix(docker): adjust Jetty connection idle timeout and update thread s…

8edf2de

…ettings for virtual threads Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>

Revert testing stuff

6da2a87

stirlingbot Bot removed Front End Issues or pull requests related to front-end development Security Security-related issues or pull requests Test Testing-related issues or pull requests labels Jun 1, 2026

chore: exclude transient LibreOffice, X11, and dconf files from tempo…

3eb0a28

…rary file detection test

stirlingbot Bot added the Test Testing-related issues or pull requests label Jun 2, 2026

chore: exclude additional persistent temporary file patterns from tes…

6e6161d

…t snapshot checks again...

Ludy87 previously approved these changes Jun 5, 2026

View reviewed changes

Merge branch 'main' into docker-stuff

b76c24d

Merge branch 'main' into docker-stuff

5aef240

Frooodle requested changes Aug 6, 2026

View reviewed changes

Comment thread app/common/src/main/java/stirling/software/common/util/ProcessExecutor.java Outdated

Comment thread app/common/src/main/java/stirling/software/common/util/ProcessExecutor.java

balazs-szucs and others added 2 commits August 6, 2026 18:29

Merge branch 'main' into docker-stuff

300b8a9

fix: add local endpoint detection to UnoServerPool and skip demand fi…

dce0dcd

…le updates for remote-only configurations

balazs-szucs dismissed Ludy87’s stale review via dce0dcd August 6, 2026 16:34

Merge branch 'main' into docker-stuff

dc4640e

balazs-szucs requested review from a team as code owners August 11, 2026 13:58

balazs-szucs requested review from Frooodle and Ludy87 August 11, 2026 14:08

balazs-szucs and others added 7 commits August 13, 2026 18:03

Merge branch 'main' into docker-stuff

c70497c

Merge branch 'main' into docker-stuff

5871b48

Merge branch 'main' into docker-stuff

e7a4be0

Merge branch 'main' into docker-stuff

ac5f4b0

Merge branch 'main' into docker-stuff

385d6e7

Merge branch 'main' into docker-stuff

2878692

chore: update dynamic memory and metaspace configuration defaults in …

b119181

…init script

Uh oh!

Conversation

balazs-szucs commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of Changes

Checklist

General

Documentation

Translations (if applicable)

UI Changes (if applicable)

Testing (if applicable)

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

stirlingbot Bot commented Mar 14, 2026

🚀 PR Test Deployment

Uh oh!

balazs-szucs commented Mar 15, 2026

Uh oh!

stirlingbot Bot commented Mar 15, 2026

🚀 PR Test Deployment

Uh oh!

stirlingbot Bot commented Mar 15, 2026

🚀 PR Test Deployment

Uh oh!

balazs-szucs commented Mar 15, 2026

Uh oh!

stirlingbot Bot commented Mar 15, 2026

🚀 PR Test Deployment

Uh oh!

balazs-szucs commented Jun 2, 2026

Uh oh!

balazs-szucs commented Jun 2, 2026

Uh oh!

balazs-szucs commented Jun 11, 2026

Uh oh!

stirlingbot Bot commented Jun 11, 2026

🚀 PR Test Deployment

Uh oh!

Frooodle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

balazs-szucs commented Mar 13, 2026 •

edited

Loading