engine: update dependencies, enforce coverage, and expand tests - #7291
Closed
Ludy87 wants to merge 11 commits into
Closed
engine: update dependencies, enforce coverage, and expand tests#7291Ludy87 wants to merge 11 commits into
Ludy87 wants to merge 11 commits into
Conversation
Ludy87
requested review from
ConnorYoh,
EthanHealy01,
Frooodle,
jbrunton96 and
reecebrowne
as code owners
August 4, 2026 15:55
Replace collections.abc AsyncIterator/Iterator with AsyncGenerator/Generator in engine runtime and tests. Update ConcurrencyLimitedModel.request_stream return annotation to AsyncGenerator[StreamedResponse, None] and adjust test_config_routes._client to Generator[TestClient, None, None]. Typing-only change to reflect actual generator/async-generator return shapes; no runtime behaviour changes.
Drop redundant "# noqa: BLE001" inline comments from broad except blocks and update type annotations for async/generator signatures. Changes: remove BLE001 noqa in config.py and service.py, tighten ConcurrencyLimitedModel.request_stream return type in runtime.py to AsyncGenerator[StreamedResponse], simplify test generator annotation in test_config_routes.py, and a minor README formatting tweak. These edits align code with linting/typing rules and improve type correctness.
Add npm to the apt-get install line in docker/embedded/Dockerfile, Dockerfile.fat and Dockerfile.ultra-lite so npm is available in embedded builds. Also add an npm --version check in the ultra-lite Dockerfile. This ensures frontend/build tooling is present in the embedded images.
Relax pre-commit pins and increase ruff line-length in engine/pyproject.toml; add per-file ruff ignores and update engine/uv.lock. Apply many non-functional Python formatting and linting adjustments across scripts and test step files: consolidate multi-line strings/args, collapse long f-strings, reorder/clean imports, add # noqa markers (BLE001, E501, N806 etc.), and minor refactors to improve style and silence linters. No behavioral changes intended — changes are formatting/lint-related to satisfy tooling and reduce warnings.
Formatting-only changes across the engine: collapsed several multi-line expressions into single-line forms, tightened f-strings and SQL literals, and removed extraneous line breaks/parentheses. Affected files include the tool model generator, multiple agents (contradiction, ledger, math_presentation, pdf_edit, pdf_questions), document stores (pgvector, sqlite, rag_capability), models (tool_io, tool_models), services (tool_io_compat, tracking), settings, and tests. No functional behavior changes intended—these edits are purely stylistic to improve readability and satisfy formatting/linting.
Contributor
Generated Models Check FailedOne or more generated files are out of date with the Java OpenAPI spec and will need to be regenerated before they can be merged in. Run |
Ludy87
marked this pull request as draft
August 11, 2026 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the AI Engine toolchain and strengthens its automated quality checks.
Changes
pytest-covand a dedicatedtask engine:test:coveragetask.Motivation
Keeping the engine dependencies current and enforcing per-file coverage improves reliability, makes regressions easier to detect, and gives contributors and reviewers accessible coverage reports.
Testing
task engine:test:coveragetask engine:checkChecklist
General
Documentation
Testing