refactor(api): move DeletingRandomAccessFile to CustomPDFDocumentFactory as a private static class - #7344
Merged
Frooodle merged 2 commits intoAug 13, 2026
Conversation
…ory as a private static class
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors PDFBox temp-file handling by relocating DeletingRandomAccessFile from an org.apache.pdfbox.examples.*-namespaced utility into CustomPDFDocumentFactory, making it a private implementation detail where it’s actually used.
Changes:
- Removed the external
org.apache.pdfbox.examples.util.DeletingRandomAccessFileclass and its import. - Added
DeletingRandomAccessFileas aprivate staticnested class withinCustomPDFDocumentFactoryto keep temp-file lifecycle logic co-located with the factory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/common/src/main/java/stirling/software/common/service/CustomPDFDocumentFactory.java | Removes the external import and inlines DeletingRandomAccessFile as a private nested implementation used by the factory. |
| app/common/src/main/java/org/apache/pdfbox/examples/util/DeletingRandomAccessFile.java | Deletes the now-unneeded standalone utility class previously living under an org.apache.pdfbox.examples.* path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Ludy87
approved these changes
Aug 13, 2026
Frooodle
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
It was in a seperate dir (app/common/src/main/java/org/apache/pdfbox/examples/util/) which i felt out of place for it.
Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)
task checkto verify linters, typechecks, and tests pass