refactor(api): replace com.fasterxml.jackson with tools.jackson (Jackson 2 to Jackson 3 namespace.) - #7444
Merged
Conversation
…son 2 to Jackson 3 namespace.)
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors selected SaaS + proprietary Java classes to use the Jackson 3 tools.jackson.* namespace (instead of com.fasterxml.jackson.*), including updating exception handling to JacksonException, in line with the repo’s Jackson 3 migration direction.
Changes:
- Switched
ObjectMapper/JsonNodeimports fromcom.fasterxml.jackson.*totools.jackson.*in multiple controllers/services/tests. - Replaced
JsonProcessingExceptioncatch blocks withJacksonExceptionwhere JSON (de)serialization is handled. - Updated supporting JSON utilities (e.g., JPA converter and Valkey job store) to the
tools.jackson.*types.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| app/saas/src/test/java/stirling/software/saas/payg/entitlement/EntitlementGuardTest.java | Updates test imports to tools.jackson (ObjectMapper, JsonNode). |
| app/saas/src/main/java/stirling/software/saas/procurement/service/ProcurementService.java | Uses tools.jackson and updates serialization exception catch to JacksonException. |
| app/saas/src/main/java/stirling/software/saas/procurement/license/KeygenEnterpriseLicenseService.java | Switches JSON types to tools.jackson namespace. |
| app/saas/src/main/java/stirling/software/saas/procurement/legal/AgreementAssembler.java | Switches ObjectMapper import to tools.jackson. |
| app/saas/src/main/java/stirling/software/saas/procurement/api/ProcurementController.java | Switches ObjectMapper import to tools.jackson. |
| app/saas/src/main/java/stirling/software/saas/payg/entitlement/EntitlementGuard.java | Switches ObjectMapper import to tools.jackson. |
| app/saas/src/main/java/stirling/software/saas/legal/LegalDocumentRegistry.java | Switches JSON types to tools.jackson namespace. |
| app/saas/src/main/java/stirling/software/saas/billing/service/StripeUsageReportingService.java | Switches ObjectMapper import to tools.jackson. |
| app/saas/src/main/java/stirling/software/saas/ai/controller/AiCreateInternalController.java | Switches to tools.jackson and updates JSON error handling to JacksonException. |
| app/saas/src/main/java/stirling/software/saas/ai/controller/AiCreateController.java | Switches to tools.jackson and updates JSON error handling to JacksonException. |
| app/proprietary/src/main/java/stirling/software/proprietary/workflow/util/WorkflowMapper.java | Switches ObjectMapper import to tools.jackson. |
| app/proprietary/src/main/java/stirling/software/proprietary/workflow/controller/SigningSessionController.java | Switches ObjectMapper import to tools.jackson. |
| app/proprietary/src/main/java/stirling/software/proprietary/storage/converter/JsonMapConverter.java | Switches JSON types to tools.jackson and updates exception handling to JacksonException. |
| app/proprietary/src/main/java/stirling/software/proprietary/cluster/valkey/ValkeyJobStore.java | Switches JSON types to tools.jackson and updates exception handling to JacksonException. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Frooodle
approved these changes
Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Should yield no behavioral change. Please use Jackson 3 namespace NOT Jackson 2. We only pulling Jackson transitively, it would be nice once everything settles to migrate fully to Jackson 3 with nothing pulling in Jackson 2, still no reason to use Jackson 2.
Changes:
Checklist
General
Documentation
Translations (if applicable)
scripts/counter_translation.pyUI Changes (if applicable)
Testing (if applicable)
task checkto verify linters, typechecks, and tests pass