Skip to content

fix: validate frontend dependency installation - #7625

Open
Ludy87 wants to merge 2 commits into
mainfrom
fix_validate_frontend_dependency
Open

fix: validate frontend dependency installation#7625
Ludy87 wants to merge 2 commits into
mainfrom
fix_validate_frontend_dependency

Conversation

@Ludy87

@Ludy87 Ludy87 commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

Description of Changes

The current check only verifies the existence of the node_modules directory. After an incomplete or corrupted installation, this can lead to the task being incorrectly marked as complete.

npm ls --depth=0 instead checks whether the direct frontend dependencies are actually installed and consistent. This reliably detects and automatically repairs corrupted installations.


Checklist

General

Documentation

Translations (if applicable)

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have run task check to verify linters, typechecks, and tests pass
  • I have tested my changes locally. Refer to the Testing Guide for more details.

@Ludy87
Ludy87 requested a review from a team as a code owner August 22, 2026 14:21
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines ignoring generated files. Bugfix Pull requests that fix bugs labels Aug 22, 2026
@Ludy87 Ludy87 added the Front End Issues or pull requests related to front-end development label Aug 22, 2026
@Ludy87
Ludy87 requested review from a team and balazs-szucs as code owners August 22, 2026 15:16
@github-actions github-actions Bot added GitHub Issues or pull requests related to GitHub configuration and integrations and removed Front End Issues or pull requests related to front-end development labels Aug 22, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚀 V2 Auto-Deployment Complete!

🔗 Direct Test URL (non-SSL) http://54.175.155.236:7625

🧩 Admin portal included - try it at http://54.175.155.236:7625/portal.

This deployment will be automatically cleaned up when the PR is closed.

🔄 Auto-deployed for approved V2 contributors.

@Ludy87 Ludy87 added the Front End Issues or pull requests related to front-end development label Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Pull requests that fix bugs Front End Issues or pull requests related to front-end development GitHub Issues or pull requests related to GitHub configuration and integrations size:XS This PR changes 0-9 lines ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants