feat(editor): move the admin directory onto TanStack Query

[ConnorYoh]

Description of Changes

Step 5 of the TanStack Query rollout, covering the admin People, Teams and Team details screens. Follows #7264, #7283, #7285.

The problem

Two separate ones, in the same three files.

Reads. Each section fetched and held its own copy of the same resources: People read the roster and the team list, Teams read the team list plus the roster again when its add-member modal opened, Team details read all three. Cost scaled with how many screens you visited rather than with how much data exists.

Writes. Thirteen handlers each did the same five things by hand: set a processing flag, call the service, toast the outcome, dig a message out of an axios error, and reload their own slice. Refreshing was a convention, not a mechanism, and one handler had already forgotten it.

The fix

Three shared query keys (adminUsers, teams, teamDetails), and one useAdminMutation helper that every write is declared against:

const createTeam = useAdminMutation({
  write: (name: string) => teamService.createTeam(name),
  invalidates: ["teams"],
  success: t("workspace.teams.createTeam.success"),
  errorFallback: t("workspace.teams.createTeam.error"),
  onDone: () => { setNewTeamName(""); setCreateModalOpened(false); },
});

Each write names the slices it disturbs, which is the part that only works when reads and writes are designed together: createTeam invalidates the team list, while a membership move invalidates the list, both teams' detail rows and the roster, because it genuinely changes all three. Invalidation refetches only mounted queries, so this costs nothing extra.

The blanket "invalidate everything" helper survives in exactly one role: child components (invite, password change, seat update) that write through their own services, where the affected scopes are not visible from the call site.

Why it is better, measured

Request counts come from one harness driving teams -> team details -> back -> people, run against the branch point and against this branch. The assertion is committed, so it cannot silently regress.

	Before	After
Requests	7	3
getTeams	4	1
getUsers	2	1
getTeamDetails	1	1
Committed renders	17	15

Three is one per distinct resource, the floor for that sequence. The four getTeams were the Teams table, Team details fetching the same list for its "move to team" dropdown, the explicit refresh on the back button, and People.

Renders barely move, which is expected: this changes where data lives, not how often React draws. It is reported because a caching change can quietly cost renders, and this one does not.

On the code itself, across the three sections:

Net lines	-216
useState/useEffect removed	11, none added
Duplicated isAxiosError blocks	13 to 1
setProcessing calls	19 to 0

isAxiosError is no longer imported by any of the three files.

Bug fixed

disableMfaByAdmin showed a success toast and never refreshed. The menu item renders only when user.mfaEnabled is true, so an admin disabled MFA, was told it worked, and watched the option stay on screen until a manual reload. It is covered by a test that fails if the invalidation is removed.

Behaviour worth checking in review

• A write no longer blocks its handler before closing the modal. The dialog closes when the write succeeds and the table updates when the refetch lands, rather than the button spinning through both.
• Modal submit buttons now track their own mutation rather than one shared flag. Team details still derives a single busy flag, now from its five mutations rather than a useState, so its row actions disable together as before.
• The per-handler console.error is kept, once, in the shared error path.

Testing

Five tests, each verified by breaking the implementation and confirming that one test, and only that one, fails:

Mutation	Caught by
Drop the shared stale window (staleTime: 0)	request-count test
Make invalidation a no-op	write-visibility test
Ignore the login-enabled gate	login-disabled test
Stop invalidating after the MFA write	MFA-refresh test
Fall back to the generic error message	server-message test

The write tests drive the real flows through their modals and menus rather than calling hooks directly.

task frontend:check passes typecheck, lint and oxfmt, and 2383 of 2385 editor tests. The two failures, workbenchSession.test.ts and notificationActions.test.tsx, are untouched here and fail identically with this branch's changes reverted.

Scope

The three services keep their current shape; nothing outside these three sections and the new hook module changes. Child modals that write through their own services still refresh via the blanket helper, and converting those is separate work.