Skip to content

fix(credits): stop pinning effectiveMonth to module-load time #1475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rajanpanth wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(credits): stop pinning effectiveMonth to module-load time #1475

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/features/credits/utils/allocateCredits.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ import { prisma } from '@/prisma';
import { CreditEventType, SubmissionLabels } from '@/prisma/enums';
import { dayjs } from '@/utils/dayjs';

const currentMonth = dayjs.utc().startOf('month').toDate();
const nextMonth = dayjs.utc().add(1, 'month').startOf('month').toDate();
const currentMonth = () => dayjs.utc().startOf('month').toDate();
const nextMonth = () => dayjs.utc().add(1, 'month').startOf('month').toDate();

type PrismaLike = Pick<typeof prisma, 'creditLedger'>;

Expand All @@ -18,7 +18,7 @@ export async function consumeCredit(
userId,
submissionId,
type: CreditEventType.SUBMISSION,
effectiveMonth: currentMonth,
effectiveMonth: currentMonth(),
change: -1,
},
});
Expand All @@ -39,7 +39,7 @@ export async function addWinBonusCredit(userId: string, submissionId: string) {
userId,
submissionId,
type: CreditEventType.WIN_BONUS,
effectiveMonth: nextMonth,
effectiveMonth: nextMonth(),
change: 1,
},
});
Expand All @@ -62,7 +62,7 @@ export async function addGrantWinBonusCredit(
userId,
applicationId,
type: CreditEventType.GRANT_WIN_BONUS,
effectiveMonth: nextMonth,
effectiveMonth: nextMonth(),
change: 1,
},
});
Expand All @@ -84,7 +84,7 @@ export async function addSpamPenaltyCredit(submissionId: string) {
userId: submission.userId,
submissionId: submission.id,
type: CreditEventType.SPAM_PENALTY,
effectiveMonth: nextMonth,
effectiveMonth: nextMonth(),
change: -1,
},
});
Expand All @@ -106,7 +106,7 @@ export async function addSpamPenaltyGrant(
userId,
applicationId,
type: CreditEventType.GRANT_SPAM_PENALTY,
effectiveMonth: nextMonth,
effectiveMonth: nextMonth(),
change: -1,
},
});
Expand All @@ -122,7 +122,7 @@ export async function addCreditDispute(
data: {
userId,
type: CreditEventType.SPAM_DISPUTE,
effectiveMonth: nextMonth,
effectiveMonth: nextMonth(),
change: 0,
submissionId: id,
decision: 'Pending',
Expand All @@ -133,7 +133,7 @@ export async function addCreditDispute(
data: {
userId,
type: CreditEventType.GRANT_SPAM_DISPUTE,
effectiveMonth: nextMonth,
effectiveMonth: nextMonth(),
change: 0,
applicationId: id,
decision: 'Pending',
Expand All @@ -156,7 +156,7 @@ export async function refundCredits(listingId: string) {
userId: submission.userId,
submissionId: submission.id,
type: CreditEventType.CREDIT_REFUND,
effectiveMonth: nextMonth,
effectiveMonth: nextMonth(),
change: +1,
},
}),
Expand Down Expand Up @@ -190,7 +190,7 @@ export async function addReferralInviterWinBonus(
userId: inviterUserId,
submissionId,
type: CreditEventType.REFERRAL_INVITEE_WIN_BONUS_INVITER,
effectiveMonth: nextMonth,
effectiveMonth: nextMonth(),
change: 1,
},
});
Expand Down Expand Up @@ -263,7 +263,7 @@ export async function awardReferralFirstSubmissionBonusesForListing(
userId,
submissionId: earliest.id,
type: CreditEventType.REFERRAL_FIRST_SUBMISSION_BONUS_INVITEE,
effectiveMonth: nextMonth,
effectiveMonth: nextMonth(),
change: 1,
},
});
Expand All @@ -282,7 +282,7 @@ export async function awardReferralFirstSubmissionBonusesForListing(
userId: inviterUserId,
submissionId: earliest.id,
type: CreditEventType.REFERRAL_FIRST_SUBMISSION_BONUS_INVITER,
effectiveMonth: nextMonth,
effectiveMonth: nextMonth(),
change: 1,
},
});
Expand Down