Skip to content

fix(likes): prevent TOCTOU race condition in updateLike with prisma transaction (#1435) #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jihadMo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(likes): prevent TOCTOU race condition in updateLike with prisma transaction (#1435) #1482

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
160 changes: 83 additions & 77 deletions src/services/likeService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,96 +5,102 @@ export async function updateLike(
itemId: string,
userId: string,
) {
let result;
return await prisma.$transaction(async (tx) => {
let result: any;

if (model === 'submission') {
result = await prisma.submission.findFirst({
where: {
id: itemId,
},
});
} else if (model === 'poW') {
result = await prisma.poW.findFirst({
where: {
id: itemId,
},
});
} else if (model === 'grantApplication') {
result = await prisma.grantApplication.findFirst({
where: {
id: itemId,
},
});
} else {
throw new Error('Invalid model provided');
}
if (model === 'submission') {
result = await tx.submission.findUnique({
where: {
id: itemId,
},
});
} else if (model === 'poW') {
result = await tx.poW.findUnique({
where: {
id: itemId,
},
});
} else if (model === 'grantApplication') {
result = await tx.grantApplication.findUnique({
where: {
id: itemId,
},
});
} else {
throw new Error('Invalid model provided');
}

if (!result) {
throw new Error(`${model} with id ${itemId} not found`);
}

let newLikes = [];
const resLikes = result?.like as {
id: string;
date: number;
}[];
let newLikes = [];
const resLikes = (result.like as {
id: string;
date: number;
}[]) || [];

if (resLikes?.length > 0) {
const like = resLikes.find((e) => e?.id === userId);
if (like) {
newLikes = resLikes.filter((e) => e.id !== userId);
if (resLikes.length > 0) {
const like = resLikes.find((e) => e?.id === userId);
if (like) {
newLikes = resLikes.filter((e) => e.id !== userId);
} else {
newLikes = [
...resLikes,
{
id: userId,
date: Date.now(),
},
];
}
} else {
newLikes = [
...resLikes,
{
id: userId,
date: Date.now(),
},
];
}
} else {
newLikes = [
{
id: userId,
date: Date.now(),
},
];
}

const likeCount = newLikes.length;
const likeCount = newLikes.length;

let updateLike;
let updateLike;

if (model === 'submission') {
updateLike = await prisma.submission.update({
where: {
id: itemId,
},
data: {
like: newLikes,
likeCount,
},
});
} else if (model === 'poW') {
updateLike = await prisma.poW.update({
where: {
id: itemId,
},
data: {
like: newLikes,
likeCount,
},
});
} else if (model === 'grantApplication') {
updateLike = await prisma.grantApplication.update({
where: {
id: itemId,
},
data: {
like: newLikes,
likeCount,
},
});
}
if (model === 'submission') {
updateLike = await tx.submission.update({
where: {
id: itemId,
},
data: {
like: newLikes,
likeCount,
},
});
} else if (model === 'poW') {
updateLike = await tx.poW.update({
where: {
id: itemId,
},
data: {
like: newLikes,
likeCount,
},
});
} else if (model === 'grantApplication') {
updateLike = await tx.grantApplication.update({
where: {
id: itemId,
},
data: {
like: newLikes,
likeCount,
},
});
}

return {
likesIncremented: likeCount > (result?.likeCount || 0),
updatedData: updateLike,
};
return {
likesIncremented: likeCount > (result.likeCount || 0),
updatedData: updateLike,
};
});
}