input: fix some binding regressions after strong typing rework#359
Merged
Supreeeme merged 4 commits intoJun 12, 2026
Merged
Conversation
ImSapphire
changed the title
ImSapphire
force-pushed
the
sapphire/fix/oculus-touch-squeeze-trigger-click
branch
from
2dcf43c to
8134b29
Compare
1 task
Supreeeme
reviewed
May 25, 2026
| "x" => Some(Self::X), | ||
| "y" => Some(Self::Y), | ||
| "application_menu" => Some(Self::Menu), | ||
| "application_menu" | "system" => Some(Self::Menu), |
Owner
There was a problem hiding this comment.
I am not positive "system" should map to the menu button.
Contributor
Author
There was a problem hiding this comment.
hmm, on SteamVR 'system' does mean the menu button in some cases. I'm guessing it should be mapped to Self::System and then translate it to Menu for specific controllers where necessary?
Contributor
Author
There was a problem hiding this comment.
I think I'll just drop that part and leave it to a follow-up to implement, having a hard time focusing right now..
ImSapphire
force-pushed
the
sapphire/fix/oculus-touch-squeeze-trigger-click
branch
from
015cb30 to
a59a2da
Compare
Co-authored-by: Sapphire <imsapphire0@gmail.com>
ImSapphire
force-pushed
the
sapphire/fix/oculus-touch-squeeze-trigger-click
branch
from
a59a2da to
f2ae8ad
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #358