Ticket 109 - Add allowMultipleSessions StorageClass Parameter for iSCSI Volumes#127
Open
smurfless1 wants to merge 2 commits into
Open
Ticket 109 - Add allowMultipleSessions StorageClass Parameter for iSCSI Volumes#127smurfless1 wants to merge 2 commits into
smurfless1 wants to merge 2 commits into
Conversation
Adds a new StorageClass parameter 'allowMultipleSessions' that enables multiple iSCSI sessions to a target, allowing PVCs to remount after node or pod restarts without requiring ReadWriteMany access mode. This resolves issues where ReadWriteOnce PVCs fail to remount after node restarts because Synology DSM blocks multiple sessions by default. Changes: - Add allowMultipleSessions parameter parsing in controllerserver.go - Enable multi-session when parameter is true, regardless of access mode - Add comprehensive unit tests for parameter behavior - Update README.md with parameter documentation - Update sanity tests to use iSCSI with allowMultipleSessions Bug fixes: - Fix format string mismatch in multipath.go (use %d for integer) - Fix missing dsmIp argument in nodeserver.go log statement - Fix unkeyed struct literals in iscsi.go and share.go Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
smurfless1
commented
Feb 4, 2026
| @@ -0,0 +1,324 @@ | |||
| /* | |||
| Copyright 2021 Synology Inc. | |||
Author
There was a problem hiding this comment.
What's a few years between friends?
smurfless1
commented
Feb 4, 2026
| if ee, ok := err.(utilexec.ExitError); ok { | ||
| log.Errorf("Non-zero exit code: %s", err) | ||
| err = fmt.Errorf("%s", ee.ExitStatus()) | ||
| err = fmt.Errorf("%d", ee.ExitStatus()) |
Author
There was a problem hiding this comment.
These other fixes were simply because my linter would not let it go.
smurfless1
commented
Feb 4, 2026
| log.Infof("Volume [%s]: allowMultipleSessions parameter ignored for protocol [%s]", volName, protocol) | ||
| } else if allowMultipleSessions && !multiSession { | ||
| log.Infof("Enabling multi-session for volume [%s] via allowMultipleSessions parameter", volName) | ||
| multiSession = true |
Author
There was a problem hiding this comment.
This was mentioned in the discussion of ticket 109. I simply had Claude help me through implementing it in a clear way.
I'm actually running this version on my NAS and have had k3s and microk8s quite happy with it for a week and change, so I'm happy so far.
smurfless1
commented
Feb 4, 2026
| } | ||
| } | ||
|
|
||
| func TestCreateVolume_AllowMultipleSessions(t *testing.T) { |
Author
There was a problem hiding this comment.
I was particularly stern with Claude that we must have tests for the new functionality. They mostly center on configuration, but as really the change is mostly about configuration, I shouldn't be surprised.
Author
|
Issue link with really good root cause discussion: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
New Feature:
Bug Fixes:
Code Quality:
Test Updates: