Open
Conversation
Hyobi-Lim
reviewed
Jun 9, 2025
| <DailyForecastWrapper> | ||
| {dailyData.map((day, index) => ( | ||
| <DailyItem key={index}> | ||
| <span>{day.date}</span> |
Hyobi-Lim
reviewed
Jun 9, 2025
| <HourlyForecastWrapper> | ||
| {hourlyData.map((item, index) => ( | ||
| <HourlyItem key={index}> | ||
| <p>{item.time}</p> |
There was a problem hiding this comment.
여기서는 p태그를 쓰셨는데 다르게 하신 이유가 따로 있나요??
없다면 태그의 특성을 고려해서 더 적합한 걸로 써주는게 좋을 것 같아요!
https://inpa.tistory.com/entry/HTML-%F0%9F%93%9A-p-div-span-%ED%83%9C%EA%B7%B8-%EC%A0%95%EB%A6%AC
⬆️ 해당 사이트 참고하면 좋을 것 같습니다!
|
나머지 부분은 구현 잘 해주셨습니다~! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.