Open
Conversation
Member
seunghui-park
left a comment
seunghui-park
left a comment
There was a problem hiding this comment.
과제하느라 고생 많으셨습니다!
8주차 팀플 파이팅 하십셔 !!!! 3팀 팟팅 ~~
| const CurrentWeather = ({ weatherData, isLoading }) => { | ||
| if (isLoading) { | ||
| return <div>채워주세요</div>; | ||
| return <div>현재날씨 로딩중...</div>; |
Member
There was a problem hiding this comment.
메시지 하드 코딩 보다는 별도의 컴포넌트 활용해 보시면 좋을 듯 합니당
Comment on lines
+42
to
+46
| <h3> | ||
| 현재 위치 : 서울 | ||
| <br /> | ||
| 현재 시각 : {new Date(currentData.time).getHours()}시 | ||
| </h3> |
Member
There was a problem hiding this comment.
h3 태그 안에 br 태그를 사용하는 건 시멘틱 구조 상 좋지 않아 보입니다!
별도의 태그로 감싸는 게 더 좋을 것 같아요
|
|
||
| const hourlyData = []; | ||
|
|
||
| for (let i = 0; i < 12; i++) { |
Member
There was a problem hiding this comment.
여기서는 크게 상관 없을 수 있지만,
여러 곳에서 사용 되거나 로직 상 의미가 있거나 자주 변경될 가능성이 있는 값은 상수 분리를 하는 게 좋습니다! 다음부터는 상수 분리에 대한 고민도 하면서 구현하시면 좋을 것 같습니당
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.