Open
Conversation
Member
seunghui-park
left a comment
seunghui-park
left a comment
There was a problem hiding this comment.
과제하느라 고생 많으셨습니다 :)
8주차 부터 진행하는 팀플 파이팅 하십셔 👍
|
|
||
| return ( | ||
| <CurrentWeatherWrapper> | ||
| <Temperature>{currentTemp}°C</Temperature> |
Member
There was a problem hiding this comment.
온도 소수점까지 반환하던데 날씨 앱에서 보통 소수점까진 출력 안하니 반올림해도 괜찮을 것 같습미당
| <DailyItem key={index}> | ||
| <div>{day.date}</div> | ||
| <div>{getWeatherDescription(day.code)}</div> | ||
| <div>{day.temp}°C</div> |
Comment on lines
+33
to
46
| for (let i = 0; i < times.length; i++) { | ||
| const hour = new Date(times[i]).getHours(); | ||
| if (hour >= currentHour && result.length < 12) { | ||
| result.push({ | ||
| time: `${hour}시`, | ||
| temp: temps[i], | ||
| code: codes[i], | ||
| }); | ||
| } | ||
| if (result.length >= 12) break; | ||
| } | ||
|
|
||
| return result; | ||
| }; |
Member
There was a problem hiding this comment.
for (let i = 0; i < times.length && result.length < 12; i++) {
const hour = new Date(times[i]).getHours();
if (hour >= currentHour) {
result.push({
time: `${hour}시`,
temp: temps[i],
code: codes[i],
});
}
}
반복문 조건에 추가하면 어떨까요?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.