[#13591] Update frontend for new search#13713
[#13591] Update frontend for new search#13713samuelfangjw merged 13 commits intoTEAMMATES:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the Angular search UIs/components to better align with the new backend search behavior by adjusting user guidance text and improving how search terms are highlighted in instructor search results.
Changes:
- Propagates a new flag to enable partial-match term highlighting in the instructor search student results table.
- Removes outdated “search tips” text from instructor/admin search pages and updates related snapshots.
- Adds a unit test and snapshot updates for the student list highlighting behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html | Passes a new highlighting flag down into the student list component for instructor search results. |
| src/web/app/pages-instructor/instructor-search-page/instructor-search-bar/instructor-search-bar.component.html | Removes outdated instructor search tips content. |
| src/web/app/pages-instructor/instructor-search-page/snapshots/instructor-search-page.component.spec.ts.snap | Snapshot updates reflecting removal of instructor search tips. |
| src/web/app/pages-admin/admin-search-page/admin-search-page.component.html | Removes outdated admin search tips content. |
| src/web/app/pages-admin/admin-search-page/snapshots/admin-search-page.component.spec.ts.snap | Snapshot updates reflecting removal of admin search tips. |
| src/web/app/components/student-list/student-list.component.ts | Adds an input to control partial-match highlighting and threads it into the highlighter pipe usage. |
| src/web/app/components/student-list/student-list.component.spec.ts | Adds a unit test verifying partial-match highlighting when enabled. |
| src/web/app/components/student-list/snapshots/student-list.component.spec.ts.snap | Snapshot updates to include the new input. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
f916c97 to
0dabd0a
Compare
|
@PhoebeY05, what was the original issue that caused the regression? |
I think it was mostly a wiring issue, the highlighting flag was not propagated to the student results table component so only whole word highlighting which was enabled by default occurred. This can be seen in |
Fixes #13591
Outline of Solution