Skip to content

[#13591] Update frontend for new search#13713

Merged
samuelfangjw merged 13 commits intoTEAMMATES:masterfrom
PhoebeY05:fix-frontend-solr-migration
Apr 14, 2026
Merged

[#13591] Update frontend for new search#13713
samuelfangjw merged 13 commits intoTEAMMATES:masterfrom
PhoebeY05:fix-frontend-solr-migration

Conversation

@PhoebeY05
Copy link
Copy Markdown
Contributor

@PhoebeY05 PhoebeY05 commented Apr 4, 2026

Fixes #13591

Outline of Solution

  • Fix partial text highlighting in Instructor Search
  • Escape regex metacharacters

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Angular search UIs/components to better align with the new backend search behavior by adjusting user guidance text and improving how search terms are highlighted in instructor search results.

Changes:

  • Propagates a new flag to enable partial-match term highlighting in the instructor search student results table.
  • Removes outdated “search tips” text from instructor/admin search pages and updates related snapshots.
  • Adds a unit test and snapshot updates for the student list highlighting behavior.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/web/app/pages-instructor/instructor-search-page/student-result-table/student-result-table.component.html Passes a new highlighting flag down into the student list component for instructor search results.
src/web/app/pages-instructor/instructor-search-page/instructor-search-bar/instructor-search-bar.component.html Removes outdated instructor search tips content.
src/web/app/pages-instructor/instructor-search-page/snapshots/instructor-search-page.component.spec.ts.snap Snapshot updates reflecting removal of instructor search tips.
src/web/app/pages-admin/admin-search-page/admin-search-page.component.html Removes outdated admin search tips content.
src/web/app/pages-admin/admin-search-page/snapshots/admin-search-page.component.spec.ts.snap Snapshot updates reflecting removal of admin search tips.
src/web/app/components/student-list/student-list.component.ts Adds an input to control partial-match highlighting and threads it into the highlighter pipe usage.
src/web/app/components/student-list/student-list.component.spec.ts Adds a unit test verifying partial-match highlighting when enabled.
src/web/app/components/student-list/snapshots/student-list.component.spec.ts.snap Snapshot updates to include the new input.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PhoebeY05 PhoebeY05 force-pushed the fix-frontend-solr-migration branch from f916c97 to 0dabd0a Compare April 6, 2026 04:35
@PhoebeY05 PhoebeY05 marked this pull request as ready for review April 6, 2026 05:14
@samuelfangjw
Copy link
Copy Markdown
Member

@PhoebeY05, what was the original issue that caused the regression?

@PhoebeY05 PhoebeY05 changed the title [#13591] Update frontend for new Solr search [#13591] Update frontend for new search Apr 6, 2026
@PhoebeY05
Copy link
Copy Markdown
Contributor Author

@PhoebeY05, what was the original issue that caused the regression?

I think it was mostly a wiring issue, the highlighting flag was not propagated to the student results table component so only whole word highlighting which was enabled by default occurred.

This can be seen in SearchTermsHighlighterPipe where isPartialMatch is an optional argument that needs to be set to true.

@PhoebeY05 PhoebeY05 requested a review from samuelfangjw April 8, 2026 06:49
@samuelfangjw samuelfangjw requested review from AaronToh and TobyCyan and removed request for samuelfangjw April 13, 2026 15:28
Copy link
Copy Markdown
Contributor

@AaronToh AaronToh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Phoebe this LGTM.

Copy link
Copy Markdown
Contributor

@TobyCyan TobyCyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@samuelfangjw samuelfangjw merged commit 68187d1 into TEAMMATES:master Apr 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace Solr-based search with PostgreSQL full-text search

5 participants