[#13710] Fix: Enable row expansion for account requests#13715
[#13710] Fix: Enable row expansion for account requests#13715shruthikha wants to merge 6 commits intoTEAMMATES:masterfrom
Conversation
Added click handler to account request rows to toggle showLinks and enable expand/collapse functionality.
|
Hi @shruthikha, thank you for your interest in contributing to TEAMMATES!
Please address the above before we proceed to review your PR. |
|
Sorry for the delay, this didn't look right and I needed time to investigate. There's a more fundamental issue here. While these share some commonalities, fundamentally the user intent is completely different. One is meant to be used in the approval/rejection of account requests flow, the other is meant to be used in the search flow (retrieving links, identifying user data, resetting account requests etc). This is a bad candidate for abstraction. To properly fix this will require splitting the @shruthikha, would you like to work on this, else I'll go ahead to close this PR and rework the issue description. |
|
Thanks for the detailed explanation!! That makes sense. |
[#13710] Admin Search: Unable to expand account requests row
Fixes #13710
Outline of Solution:
-> Added click handler to account request rows:
(click)="accountRequest.showLinks = !accountRequest.showLinks"-> This enables expand/collapse functionality for account requests
-> Aligns behavior with instructor and student tables where row click toggles details