Skip to content

[#13710] Fix: Enable row expansion for account requests#13715

Open
shruthikha wants to merge 6 commits intoTEAMMATES:masterfrom
shruthikha:master
Open

[#13710] Fix: Enable row expansion for account requests#13715
shruthikha wants to merge 6 commits intoTEAMMATES:masterfrom
shruthikha:master

Conversation

@shruthikha
Copy link
Copy Markdown

[#13710] Admin Search: Unable to expand account requests row

Fixes #13710

Outline of Solution:
-> Added click handler to account request rows:
(click)="accountRequest.showLinks = !accountRequest.showLinks"
-> This enables expand/collapse functionality for account requests
-> Aligns behavior with instructor and student tables where row click toggles details

Added click handler to account request rows to toggle showLinks and enable expand/collapse functionality.
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 4, 2026

Hi @shruthikha, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contributing guidelines:

  • Title must start with the issue number the PR is fixing in square brackets, e.g. [#<issue-number>]

Please address the above before we proceed to review your PR.

@shruthikha shruthikha changed the title Fix: Enable row expansion for account requests [#13710] Fix: Enable row expansion for account requests Apr 4, 2026
@samuelfangjw
Copy link
Copy Markdown
Member

Sorry for the delay, this didn't look right and I needed time to investigate.

There's a more fundamental issue here. account-request-table should not be used for both pending account requests and admin search page.

While these share some commonalities, fundamentally the user intent is completely different. One is meant to be used in the approval/rejection of account requests flow, the other is meant to be used in the search flow (retrieving links, identifying user data, resetting account requests etc). This is a bad candidate for abstraction.

To properly fix this will require splitting the account-request-table into two components, one for the pending account requests page and one for the admin search page.

@shruthikha, would you like to work on this, else I'll go ahead to close this PR and rework the issue description.

@shruthikha
Copy link
Copy Markdown
Author

Thanks for the detailed explanation!! That makes sense.
Yes, I’d like to work on this. I’ll refactor the component by splitting it into separate components for the pending requests page and the admin search page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Admin Search: Unable to expand account requests row

2 participants