[#13635] Add more editable templates into custom-email-template feature#13737
Open
WeeJean wants to merge 47 commits intoTEAMMATES:feature/custom-email-templatesfrom
Open
[#13635] Add more editable templates into custom-email-template feature#13737WeeJean wants to merge 47 commits intoTEAMMATES:feature/custom-email-templatesfrom
WeeJean wants to merge 47 commits intoTEAMMATES:feature/custom-email-templatesfrom
Conversation
…ail-expansion # Conflicts: # src/it/java/teammates/it/sqllogic/api/EmailGeneratorTestIT.java # src/test/java/teammates/sqlui/webapi/GetActionClassesActionTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #13635
Description
This PR completes the end-to-end integration of the Configurable Email Template System. Building on the infrastructure from #3, it migrates all remaining 21 system email templates into the
ConfigurableEmailTemplateregistry.By moving away from hardcoded Java constants to a database-first approach, we now allow administrators to safely override any system email at runtime via the Admin UI.
Key Changes
Backend & Migration
required placeholder sets, automatically enforced by the existing validation guard.
src/main/resources/, replacing previously inline-only Java strings.[Email Copy]subject prefix for co-owner notifications, which was previously bypassed by the new setter.Infrastructure & Build Fixes
EMAIL_TEMPLATEandEMAIL_TEMPLATESto theResourceEndpointsJava enum. This fixes the CI build failure whereapi-const.tswas being regenerated without these keys.awaiting.sessiontest data (+30 days) to prevent regressions caused by sessions falling into the past during execution.Frontend & Linting
AdminEmailTemplatesPageand resolved all ESLint violations regarding import ordering and template string literals.Migrated Templates (22 total)
Not Migrated (3)