Skip to content

Issue #251: add github action to test for dependency errors#253

Merged
geourjoa merged 17 commits intoTETRAS-IIIF:mainfrom
paulhectork:aiiinotate
Apr 15, 2026
Merged

Issue #251: add github action to test for dependency errors#253
geourjoa merged 17 commits intoTETRAS-IIIF:mainfrom
paulhectork:aiiinotate

Conversation

@paulhectork
Copy link
Copy Markdown
Collaborator

@paulhectork paulhectork commented Apr 14, 2026

hi @geourjoa

this is my solution for: #251 (comment)

i added a github action that tests that the package.json can be installed successfully.

i can't test the actual NPM package installation because that would need a new version of MAE to be published through NPM before merging the PR, which would be a big/weird change to your current workflow.

thanks !

@codecov-commenter
Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@paulhectork
Copy link
Copy Markdown
Collaborator Author

NOTE: testing npm install --omit=dev would be better: it excludes devDependencies, which AFAIK is equivalent to installing the NPM package.

but, when i run npm install in the Github action, for some reason, it also triggers a build, which requires vite, which is a devDependency.

@geourjoa
Copy link
Copy Markdown
Contributor

geourjoa commented Apr 14, 2026

@paulhectork

i can't test the actual NPM package installation because that would need a new version of MAE to be published through NPM before merging the PR, which would be a big/weird change to your current workflow.

There is perhaps something we can do with npm pack

I will try something

#254

@geourjoa geourjoa merged commit 3cf9936 into TETRAS-IIIF:main Apr 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants