feat(personalization): add persistent song personalization#146
Draft
JaniL wants to merge 3 commits into
Draft
Conversation
…e and song pages Implement a client-side personalization model so users can curate their own songbook view without touching shared content metadata. The home page now consumes slug-based song entries and derives favorites, hidden state, and visit-based sorting from localStorage, which enables stable behavior across reloads and future personalization extensions. This also introduces a hidden-song warning and song-level actions (favorite/hide) on the song page, while making server boundaries explicit by renaming the filesystem song loader module to serverSongs. Together these changes align issues #141-#144 under one cohesive flow.
Collaborator
Author
|
Show hidden now also counts songs that have been set hidden in content-level. Should it do that or not? |
Collaborator
|
Also, maybe a stylized between Favorites and the rest of the listing to make the distinction clearer (esp. with 3 favorites). Good contribution, thanks! A couple q's to go through and then good for merge :) |
…zation lists Ensure songs marked hidden in markdown frontmatter remain excluded from home views regardless of user personalization settings. This prevents Show hidden from surfacing content-hidden songs and keeps repository-level visibility rules authoritative. The home hidden counter and favorites section now derive from non-content-hidden songs only, so counts and favorites reflect user personalization state without leaking permanently hidden content.
…gate Remove the visibility-loading placeholder from the song page render path so static HTML always includes the song title and lyrics content on first load. This preserves crawlable content for SEO and avoids shipping a transient placeholder as the primary document body. The hidden-song warning remains client-side and still redirects away when a user cancels, but initial rendering is no longer blocked behind post-hydration state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes issue #141
Implement a client-side personalization model so users can curate their own songbook view without touching shared content metadata. The home page now consumes slug-based song entries and derives favorites, hidden state, and visit-based sorting from localStorage, which enables stable behavior across reloads and future personalization extensions.
This also introduces a hidden-song warning and song-level actions (favorite/hide) on the song page, while making server boundaries explicit by renaming the filesystem song loader module to serverSongs.