Skip to content

fix file uploads iterable type #1863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joschahenningsen merged 3 commits into from
Aug 11, 2026
Merged

fix file uploads iterable type #1863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4765071
fix file uploads iterable type
coolgirl19 Jun 27, 2026
8040ceb
Fix linter issue
coolgirl19 Jul 27, 2026
b1674da
Adapt AI suggestion
coolgirl19 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions web/ts/data-store/admin-lecture-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,9 +131,11 @@ export class AdminLectureListProvider extends StreamableMapProvider<number, Lect

this.data[courseId] = (await this.getData(courseId)).map((s) => {
if (s.lectureId === lectureId) {
const updatedFiles = [...(s.files ?? []), newFile];
return {
...s,
files: [...s.files, newFile],
files: updatedFiles,
hasAttachments: updatedFiles.some((f) => f.fileType === FileType.attachment),
};
}
return s;
Expand All @@ -146,9 +148,11 @@ export class AdminLectureListProvider extends StreamableMapProvider<number, Lect

this.data[courseId] = (await this.getData(courseId)).map((s) => {
if (s.lectureId === lectureId) {
const updatedFiles = (s.files ?? []).filter((a) => a.id !== attachmentId);
return {
...s,
files: [...s.files.filter((a) => a.id !== attachmentId)],
files: updatedFiles,
hasAttachments: updatedFiles.some((f) => f.fileType === FileType.attachment),
};
}
return s;
Expand Down
33 changes: 24 additions & 9 deletions web/ts/edit-course.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,20 +223,35 @@ export function lectureEditor(lecture: Lecture): AlpineComponent {
return this.lectureData[key];
},

onAttachmentFileDrop(e) {
if (e.dataTransfer.items) {
const item = e.dataTransfer.items[0];
const { kind } = item;
switch (kind) {
case "file": {
DataStore.adminLectureList.uploadAttachmentFile(
async onAttachmentFileDrop(e) {
const files = Array.from(e.dataTransfer?.files ?? []);

try {
if (files.length > 0) {
for (const file of files as File[]) {
await DataStore.adminLectureList.uploadAttachmentFile(
this.lectureData.courseId,
this.lectureData.lectureId,
item.getAsFile(),
file,
);
break;
}
return;
}

const droppedFile =
e.dataTransfer?.items?.[0]?.kind === "file" ? e.dataTransfer.items[0].getAsFile() : null;
if (!droppedFile) {
return;
}

await DataStore.adminLectureList.uploadAttachmentFile(
this.lectureData.courseId,
this.lectureData.lectureId,
droppedFile,
);
} catch (err) {
console.error(err);
this.lastErrors = [err.message || "Failed to upload attachment(s)"];
}
},

Expand Down
Loading