[BUGFIX] Regenerate code-php-short fixture for modal-button markup#1324
Merged
CybotTM merged 1 commit intoJul 9, 2026
Merged
Conversation
TYPO3-Documentation#1294 added the code-php-short integration test with expected output generated before TYPO3-Documentation#1305 changed the inline-code template to open the information modal via a dedicated button. Both PRs were green on their own but merged past each other, leaving main's integration suite red. Regenerate the fixture via make integration-baseline. The php-short rendering itself is unchanged: names stay stripped of the leading backslash (FooBar, Something). Signed-off-by: Sebastian Mendel <github@sebastianmendel.de>
Contributor
Author
|
Sorry! Merge was by Accident, I am really sorry! Did not recognize that I have merge privileges now. I am ashamed. |
This was referenced Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Integration tests on
mainfail since 50146a4:Every open PR inherits this failure via the merge ref (e.g. #1291, #1292).
Cause
#1294 added the
code-php-shorttest with expected output generated before #1305 changedcode.html.twig(information modal now opened via a dedicated button;data-morelinkonly emitted for a non-empty URL). Both PRs were green individually and merged past each other today.Fix
Regenerate the fixture via
make integration-baseline— onlytests/Integration/tests/code/code-php-short/expected/index.htmlchanges. Thephp-shortrendering itself is unaffected: names remain stripped of the leading backslash (FooBar,Something).Integration suite local result:
Tests: 115, Assertions: 1150— no failures.