Skip to content

reputation fix - #1085

Merged
mikewheeleer merged 1 commit into
Talenttrust:mainfrom
Glam26:reputation
Jul 30, 2026
Merged

reputation fix#1085
mikewheeleer merged 1 commit into
Talenttrust:mainfrom
Glam26:reputation

Conversation

@Glam26

@Glam26 Glam26 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

All tasks are complete! Here's a summary of what was implemented:
Changes Made

  1. src/components/ReputationErrorBoundary.tsx (new)
  • Class-based React error boundary scoped to the reputation section
  • Follows the exact same pattern as MilestonesErrorBoundary and SettingsErrorBoundary
  • Props: children , fallback (custom fallback override), onError (testing hook)
  • Reports errors via reportError(error, 'ReputationErrorBoundary', 'error', { componentStack })
  • Accessible fallback: role="alert" , aria-live="assertive" , aria-atomic="true" , autoFocus on Retry button
  • Heading: "The reputation section couldn't load." with error message and helper text
  1. src/components/tests/ReputationErrorBoundary.test.tsx (new)
  • 14 comprehensive test scenarios covering: normal render, fallback UI, accessibility attributes, autoFocus, error message display, retry recovery, persistent failure retry, custom fallback, onError callback, reportError integration (context, level, component stack), no report on clean render, multiple successive errors, and deeply nested errors
  1. src/app/reputation/ReputationPageContent.tsx (modified)
  • Replaced SafeBoundary wrapper with ReputationErrorBoundary
  • Updated import accordingly
  1. src/app/reputation/tests/page.test.tsx (modified)
  • Updated all error boundary text assertions from "This section failed to load." to "The reputation section couldn't load." using regex matchers (for smart quote ’ compatibility)
  • Updated "Go Home" assertions from presence to absence (since ReputationErrorBoundary doesn't include it)
  • Updated describe block name from "SafeBoundary fallback" to "ReputationErrorBoundary fallback"
    Tests: All 73 tests pass (14 component tests + 59 page integration tests).

closes #625

@drips-wave

drips-wave Bot commented Jul 30, 2026

Copy link
Copy Markdown

@Glam26 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mikewheeleer
mikewheeleer merged commit 76f340e into Talenttrust:main Jul 30, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrap the reputation section in an error boundary with a retry

3 participants