feat: add user setting to show ingredient notes inline#4704
Open
guguinhaaax wants to merge 1 commit into
Open
Conversation
Fixes TandoorRecipes#455 Previously, ingredient notes were hidden behind a tooltip icon requiring a hover or tap to view. This made notes hard to discover and inconvenient to use, especially on mobile devices or while cooking. This PR adds a new user preference `show_ingredient_notes` that allows users to choose whether ingredient notes are displayed inline (below the ingredient) or as a tooltip (previous behavior). Changes: - cookbook/models.py: added `show_ingredient_notes` BooleanField (default=True) - cookbook/migrations/0243_userpreference_show_ingredient_notes.py: migration for new field - cookbook/serializer.py: exposed `show_ingredient_notes` in UserPreferenceSerializer - vue3/src/components/display/IngredientsTable.vue: render note inline when setting is enabled, tooltip otherwise - vue3/src/components/settings/CosmeticSettings.vue: added checkbox to toggle the setting - vue3/src/locales/en.json: added translation strings for the new setting
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #455
Previously, ingredient notes were hidden behind a tooltip icon requiring a hover or tap to view. This made notes hard to discover and inconvenient to use, especially on mobile devices or while cooking.
This PR adds a new user preference
show_ingredient_notesthat allows users to choose whether ingredient notes are displayed inline (below the ingredient) or as a tooltip (previous behavior).Changes:
show_ingredient_notesBooleanField (default=True)show_ingredient_notesin UserPreferenceSerializer