Skip to content

[Fix] fix the issue uploadBloomingStatus not compiled when clause#138

Merged
LeeHanEum merged 1 commit intodevelopfrom
fix/comileKotlin-flowerspotcafe
Mar 27, 2026
Merged

[Fix] fix the issue uploadBloomingStatus not compiled when clause#138
LeeHanEum merged 1 commit intodevelopfrom
fix/comileKotlin-flowerspotcafe

Conversation

@LeeHanEum
Copy link
Copy Markdown
Collaborator

@LeeHanEum LeeHanEum commented Mar 27, 2026

🌱 관련 이슈

  • close #

📌 작업 내용 및 특이 사항

  • when 절 때문에 컴파일 에러 나는 문제 해결

📝 참고

📌 체크 리스트

  • 리뷰어를 추가하셨나요 ?
  • 변경사항에 대해 충분히 설명하고 있나요 ?

Summary by CodeRabbit

  • Refactor
    • Simplified internal control flow logic for image upload handling to improve code maintainability. No changes to user-facing functionality.

@LeeHanEum LeeHanEum self-assigned this Mar 27, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Mar 27, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 39efe839-65ab-42ec-9c19-e24c967552a8

📥 Commits

Reviewing files that changed from the base of the PR and between c037562 and 9b04936.

📒 Files selected for processing (1)
  • pida-core/core-domain/src/main/kotlin/com/pida/blooming/BloomingFacade.kt

📝 Walkthrough

Walkthrough

A single-file refactoring in BloomingFacade.uploadBloomingStatus replaces a when expression with a simpler if conditional, maintaining equivalent behavior for post-upload side-effect handling without altering external or public interfaces.

Changes

Cohort / File(s) Summary
Refactored Conditional Logic
pida-core/core-domain/src/main/kotlin/com/pida/blooming/BloomingFacade.kt
Simplified post-upload side-effect handling by replacing a when branch with an if conditional that checks for NewBlooming.FlowerSpot type. Behavior remains unchanged; non-FlowerSpot cases continue as no-op.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 A cleaner path through blooming code,
Where when becomes if, lighter the load,
Same flowers thrive, same logic flows,
Just simpler now—as elegance shows! 🌸

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/comileKotlin-flowerspotcafe

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LeeHanEum LeeHanEum merged commit fcb4790 into develop Mar 27, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant