Project Design Handoff - #40
Open
Amanda-Sjstrm wants to merge 15 commits into
Open
Conversation
EmmaHoltegaard
left a comment
EmmaHoltegaard
left a comment
There was a problem hiding this comment.
Sorry for leaving almost no comments, but there's really not much to say except that everything looks great. The idea of splitting styled components into their own files is not a bad idea! A lot of code, but everything is very neat at structured, and easy to read (even the stuff that I don't really understand myself). Awesome :)
| }; | ||
|
|
||
| const getCardsForSelectedCity = () => { | ||
| switch (selectedCity) { |
There was a problem hiding this comment.
This switch case-thing is super unfamiliar to me, nice to see it in action!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dancing-taiyaki-4c46b2.netlify.app/