[DCK] Replace pip and poetry with uv#662
Open
david-banon-tecnativa wants to merge 2 commits intomasterfrom
Open
[DCK] Replace pip and poetry with uv#662david-banon-tecnativa wants to merge 2 commits intomasterfrom
david-banon-tecnativa wants to merge 2 commits intomasterfrom
Conversation
ap-wtioit
reviewed
Jun 4, 2025
11.0.Dockerfile
Outdated
|
|
||
| # Debian stretch was moved to archive (and stretch-updates does not exist in archive) | ||
| RUN sed -i 's,http://deb.debian.org,http://archive.debian.org,g;s,http://security.debian.org,http://archive.debian.org,g;s,\(.*stretch-updates\),#\1,' /etc/apt/sources.list | ||
| COPY --from=ghcr.io/astral-sh/uv:latest /uv /uvx /bin/ |
Contributor
There was a problem hiding this comment.
As this is the first time using the COPY --from, we should make an announcement that certain docker versions will be unsupported. If there is already one can you add a link to it.
Edit: seems the discussion is locked: #67 but it would belong there i guess.
Contributor
Author
There was a problem hiding this comment.
An announcement will be made once we ensure this will be merged at some point and isn't just an experiment.
However, as this is run on CI, anyone should be able to just pull the doodba image i think, even if they are running a docker version prior to 17.05 (I think that is when COPY --from was implemented)
This comment was marked as resolved.
This comment was marked as resolved.
david-banon-tecnativa
force-pushed
the
dck-imp-use_uv
branch
5 times, most recently
from
f0f214f to
519e6cb
Compare
|
go go go! |
Member
|
Please check the failing CI. |
david-banon-tecnativa
force-pushed
the
dck-imp-use_uv
branch
5 times, most recently
from
96bbd04 to
902d02b
Compare
david-banon-tecnativa
force-pushed
the
dck-imp-use_uv
branch
from
902d02b to
e26dbe6
Compare
david-banon-tecnativa
force-pushed
the
dck-imp-use_uv
branch
from
e26dbe6 to
29f0d87
Compare
david-banon-tecnativa
force-pushed
the
dck-imp-use_uv
branch
from
29f0d87 to
2c73d11
Compare
david-banon-tecnativa
force-pushed
the
dck-imp-use_uv
branch
from
2c73d11 to
31314d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces pip with UV in pip compatibility mode, in my tests speeds build times between 15% and 40% depending on the project and how many python packages it installs.
Should not cause any difference in the final image in terms of packages, but some testing is still needed.
Also replaces poetry as a package manager for the project also with uv.
@Tecnativa @pedrobaeza @josep-tecnativa