add wait for idle and disable scroll and textview cursor in tests - #7
Merged
Conversation
dnieto-r
requested review from
a team,
hjorrod,
jeprubio and
jeslat
and removed request for
a team
September 4, 2025 07:54
jeprubio
approved these changes
Sep 4, 2025
dnieto-r
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
ANDROID-16401
🥅 What's the goal?
After testing the app for several days, we noticed that sometimes some screenshots were regenerated because it didn't wait for the ripple animations to finish, or the scrollbar appeared halfway through, etc. The goal of this PR is to fix these issues.
🚧 How do we do it?
To fix this, we analyzed the shot library and saw that it used the disableFlakyComponentsAndWaitForIdle() function, which hides the scroll view and waits for animations to finish, so we added that same code with some adaptations.