Update Dark Variant to Use textActivated Color for Selected TabBar Items - #2448
Closed
pbartolome wants to merge 1 commit into
Closed
Update Dark Variant to Use textActivated Color for Selected TabBar Items#2448pbartolome wants to merge 1 commit into
pbartolome wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the dark variant's textActivated color to use vivoPurpleLight20 instead of vivoPurpleLight80 to ensure proper visual contrast for selected TabBar items in Liquid Glass with dark backgrounds.
Key Changes:
- Updated
textActivatedtoken value fromvivoPurpleLight80tovivoPurpleLight20 - Updated corresponding description to reflect the new palette reference
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TabBar text and icons in the selected state use the textActivated color, when rendered in Liquid Glass with a dark background we need to redefine the current dark variant.
This is not a breaking change: the dark variant is not used in Vivo so updating its values will not affect current behavior outside the Liquid Glass context.