fix(linter): Fix workflow and format fails - #2565
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issues with the token linting workflow by refining the conditions under which the linter is triggered and correcting the format of a description in the token JSON file.
Motivation
The previous configuration for the token linting workflow was set to trigger on pushes to the production branch, which limited its effectiveness during pull requests. By changing the trigger to
pull_request, we ensure that any changes to the token files are validated before they are merged, enhancing our code quality and consistency.Changes Made
tokens-lint.ymlworkflow has been modified to trigger on pull requests targeting the production branch instead of on direct pushes. This change allows for better validation during the development process.tokens/vivo.jsonfile, the description for thebackgroundDropZoneBrandDragoverkey has been corrected from "darkModeBlack" to "vivoPurpleDark" to accurately reflect the associated color.Improvement
These changes improve the project by ensuring that token formatting is validated during pull requests, reducing the likelihood of errors in the production branch. The correction in the token description also enhances clarity and maintainability of our design tokens.