Skip to content

feat(skin): Add backgroundSelected, backgroundSelectedHover and backgroundSelectedPressed tokens - #2664

Merged
yceballost merged 3 commits into
productionfrom
2614-side-navigation
Jun 30, 2026
Merged

feat(skin): Add backgroundSelected, backgroundSelectedHover and backgroundSelectedPressed tokens#2664
yceballost merged 3 commits into
productionfrom
2614-side-navigation

Conversation

@aweell

@aweell aweell commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Description: feat(skin): Add backgroundSelected, backgroundSelectedHover, and backgroundSelectedPressed tokens

Motivation

This pull request introduces three new design tokens: backgroundSelected, backgroundSelectedHover, and backgroundSelectedPressed. These tokens are essential for enhancing the user interface by providing consistent and intuitive feedback when users interact with selected elements across different themes and palettes.

Changes Made

  • Added the new tokens to various JSON files that define color schemes for different brands and themes.
  • Each token is defined with RGBA values that utilize existing palette colors, ensuring they align with the overall design language of the project.
  • The new tokens will allow for a smoother and more visually cohesive experience when elements are selected, hovered over, or pressed.

Improvement to the Project

By integrating these new tokens, we improve the usability and accessibility of the UI components. The added background states provide clear visual cues to users, making interactions more intuitive. This change will also streamline future UI updates by centralizing color definitions, promoting consistency across the application. Overall, these enhancements will contribute to a more polished and user-friendly interface.

@aweell aweell linked an issue Jun 29, 2026 that may be closed by this pull request
4 tasks

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds three new skin background state tokens (backgroundSelected, backgroundSelectedHover, backgroundSelectedPressed) across all provided skins (light + dark) and updates the skin JSON schema so these tokens are formally required/validated.

Changes:

  • Introduces backgroundSelected* tokens in each skin token file, with consistent alpha steps for default/hover/pressed states.
  • Adds dark-mode equivalents for the same tokens in each skin.
  • Updates tokens/schema/skin-schema.json to include the new tokens in both the required list and properties.

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tokens/vivo.json Adds backgroundSelected* tokens for light/dark using vivo palette colors.
tokens/vivo-new.json Adds backgroundSelected* tokens for light/dark using vivo palette colors.
tokens/vivo-evolution.json Adds backgroundSelected* tokens for light/dark using evolution palette colors.
tokens/unbranded.json Adds backgroundSelected* tokens for light/dark using neutral/black palette colors.
tokens/tu.json Adds backgroundSelected* tokens for light/dark using TU blues.
tokens/telefonica.json Adds backgroundSelected* tokens for light/dark using Telefónica blues.
tokens/o2.json Adds backgroundSelected* tokens for light/dark using O2 blues.
tokens/o2-new.json Adds backgroundSelected* tokens for light/dark using Beyond Blue palette.
tokens/movistar.json Adds backgroundSelected* tokens for light/dark using Movistar palette.
tokens/movistar-new.json Adds backgroundSelected* tokens for light/dark using dark-mode palette in dark section.
tokens/esimflag.json Adds backgroundSelected* tokens for light/dark using blue palette.
tokens/community/cyber.json Adds backgroundSelected* tokens for light/dark using brand/darkModeBrand palette.
tokens/blau.json Adds backgroundSelected* tokens for light/dark using blau palette.
tokens/schema/skin-schema.json Extends schema to require and define the new tokens.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@AnaMontes11 AnaMontes11 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@yceballost
yceballost added this pull request to the merge queue Jun 30, 2026
Merged via the queue into production with commit 1b36b26 Jun 30, 2026
15 checks passed
@yceballost
yceballost deleted the 2614-side-navigation branch June 30, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Side navigation

4 participants