feat(skin): Add backgroundSelected, backgroundSelectedHover and backgroundSelectedPressed tokens - #2664
Merged
Merged
Conversation
4 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Adds three new skin background state tokens (backgroundSelected, backgroundSelectedHover, backgroundSelectedPressed) across all provided skins (light + dark) and updates the skin JSON schema so these tokens are formally required/validated.
Changes:
- Introduces
backgroundSelected*tokens in each skin token file, with consistent alpha steps for default/hover/pressed states. - Adds dark-mode equivalents for the same tokens in each skin.
- Updates
tokens/schema/skin-schema.jsonto include the new tokens in both therequiredlist andproperties.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tokens/vivo.json | Adds backgroundSelected* tokens for light/dark using vivo palette colors. |
| tokens/vivo-new.json | Adds backgroundSelected* tokens for light/dark using vivo palette colors. |
| tokens/vivo-evolution.json | Adds backgroundSelected* tokens for light/dark using evolution palette colors. |
| tokens/unbranded.json | Adds backgroundSelected* tokens for light/dark using neutral/black palette colors. |
| tokens/tu.json | Adds backgroundSelected* tokens for light/dark using TU blues. |
| tokens/telefonica.json | Adds backgroundSelected* tokens for light/dark using Telefónica blues. |
| tokens/o2.json | Adds backgroundSelected* tokens for light/dark using O2 blues. |
| tokens/o2-new.json | Adds backgroundSelected* tokens for light/dark using Beyond Blue palette. |
| tokens/movistar.json | Adds backgroundSelected* tokens for light/dark using Movistar palette. |
| tokens/movistar-new.json | Adds backgroundSelected* tokens for light/dark using dark-mode palette in dark section. |
| tokens/esimflag.json | Adds backgroundSelected* tokens for light/dark using blue palette. |
| tokens/community/cyber.json | Adds backgroundSelected* tokens for light/dark using brand/darkModeBrand palette. |
| tokens/blau.json | Adds backgroundSelected* tokens for light/dark using blau palette. |
| tokens/schema/skin-schema.json | Extends schema to require and define the new tokens. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yceballost
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description: feat(skin): Add backgroundSelected, backgroundSelectedHover, and backgroundSelectedPressed tokens
Motivation
This pull request introduces three new design tokens:
backgroundSelected,backgroundSelectedHover, andbackgroundSelectedPressed. These tokens are essential for enhancing the user interface by providing consistent and intuitive feedback when users interact with selected elements across different themes and palettes.Changes Made
Improvement to the Project
By integrating these new tokens, we improve the usability and accessibility of the UI components. The added background states provide clear visual cues to users, making interactions more intuitive. This change will also streamline future UI updates by centralizing color definitions, promoting consistency across the application. Overall, these enhancements will contribute to a more polished and user-friendly interface.