Bump apache-avro dev-dependency from 0.17 to 0.21 and migrate xz2 to liblzma#39
Open
flxo wants to merge 1 commit into
Open
Bump apache-avro dev-dependency from 0.17 to 0.21 and migrate xz2 to liblzma#39flxo wants to merge 1 commit into
flxo wants to merge 1 commit into
Conversation
…liblzma apache-avro 0.21 switched its xz compression backend from lzma-sys (via xz2) to liblzma. Cargo's links resolver only allows a single package in the dependency graph to claim links = "lzma", so pulling in apache-avro 0.21 alongside our existing xz2 dependency caused resolution to fail: package `liblzma-sys` links to the native library `lzma`, but it conflicts with a previous package which links to `lzma` as well: package `lzma-sys v0.1.20` Resolve the conflict by migrating serde_avro_fast's own xz feature from xz2 (0.1) to liblzma (0.4). liblzma is a maintained successor to xz2 with an API-compatible surface, so the change is mechanical: the feature flag now pulls in liblzma, and the writer/reader simply swap the xz2:: paths for liblzma:: paths. No behavioural changes. Verified with `cargo nextest run --all-features` (156 tests pass).
Ten0
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
apache-avro0.21 switched itsxzcompression backend fromlzma-sys(viaxz2) toliblzma. Cargo's links resolver only allows a single package in the dependency graph to claim links = "lzma", so pulling inapache-avro0.21 alongside our existingxz2dependency caused resolution to fail:package
liblzma-syslinks to the native librarylzma, but itconflicts with a previous package which links to
lzmaas well:package
lzma-sys v0.1.20Resolve the conflict by migrating serde_avro_fast's own xz feature from
xz2(0.1) toliblzma(0.4).liblzmais a maintained successor toxz2with an API-compatible surface, so the change is mechanical: the feature flag now pulls in liblzma, and the writer/reader simply swap thexz2::paths forliblzma::paths. No behavioural changes.Verified with
cargo nextest run --all-features(156 tests pass).