Skip to content

Feature/scene platform resource#1606

Open
dkdicj wants to merge 1 commit into
TencentBlueKing:feature/scene-platform-resourcefrom
dkdicj:feature/scene-platform-resource
Open

Feature/scene platform resource#1606
dkdicj wants to merge 1 commit into
TencentBlueKing:feature/scene-platform-resourcefrom
dkdicj:feature/scene-platform-resource

Conversation

@dkdicj

@dkdicj dkdicj commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@0RAJA

0RAJA commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Code Review

结论:未发现明确阻塞问题。

轻微建议

  1. 测试里包含一个被校验逻辑禁止的状态

位置:src/backend/tests/test_scene/test_scene.pytest_scenes_and_systems_empty_binding,以及 src/backend/services/web/scene/binding_validation.pyassert_binding_relation_integrity

SCENES_AND_SYSTEMS 空 scene + 空 system 会被完整性校验拒绝,但测试断言这种空绑定会同步到所有场景。建议删除该 case,或改成断言校验失败,避免误导后续维护。

@dkdicj dkdicj force-pushed the feature/scene-platform-resource branch from 4b0c574 to 413d763 Compare June 18, 2026 02:58
@dkdicj dkdicj force-pushed the feature/scene-platform-resource branch from 413d763 to 67f2231 Compare June 18, 2026 02:59
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 92.98246% with 16 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feature/scene-platform-resource@93c7d46). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/backend/services/web/vision/resources.py 60.00% 8 Missing ⚠️
src/backend/services/web/tool/resources.py 64.70% 6 Missing ⚠️
...c/backend/services/web/scene/binding_validation.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@                        Coverage Diff                         @@
##             feature/scene-platform-resource    #1606   +/-   ##
==================================================================
  Coverage                                   ?   86.87%           
==================================================================
  Files                                      ?      838           
  Lines                                      ?    51299           
  Branches                                   ?        0           
==================================================================
  Hits                                       ?    44567           
  Misses                                     ?     6732           
  Partials                                   ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@0RAJA

0RAJA commented Jun 18, 2026

Copy link
Copy Markdown
Collaborator

复审结果

上次提到的 SCENES_AND_SYSTEMS 空绑定测试已删除。

本轮未发现新的阻塞问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants