Skip to content

Add build for Python 3.13 and 3.14#57

Merged
mejroslav merged 5 commits into
mainfrom
build/python-3.14
Jun 15, 2026
Merged

Add build for Python 3.13 and 3.14#57
mejroslav merged 5 commits into
mainfrom
build/python-3.14

Conversation

@mejroslav

@mejroslav mejroslav commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Added build for Python 3.13 and 3.14. Removed old builds for Python 3.6 and 3.7 GitHub workflows were created. No further action was needed.

Breaking change: cysimdjson will no longer be available for Python 3.6 and 3.7

image

@mejroslav
mejroslav requested a review from PremyslCerny June 15, 2026 11:52
@mejroslav mejroslav self-assigned this Jun 15, 2026
@coderabbitai

coderabbitai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Adds Python 3.13 and 3.14 support by introducing two new GitHub Actions CI workflows, extending the Linux wheel build script with CP313 and CP314 build blocks (now also installing setuptools), and appending the corresponding version classifiers to setup.py.

Changes

Python 3.13 and 3.14 support

Layer / File(s) Summary
CI workflows for Python 3.13 and 3.14
.github/workflows/py313.yaml, .github/workflows/py314.yaml
Two new GitHub Actions workflows trigger on push/PR to main, provision the respective Python version, conditionally install requirements.txt, install cython, build C/Cython extensions in-place via setup.py, and run the unit test suite.
Wheel build script and package classifiers
build-linux-wheel.sh, setup.py
CP312 wheel block replaced by CP313 and CP314 blocks; both install setuptools and Cython, clean cysimdjson.egg-info, and run bdist_wheel. setup.py gains Programming Language :: Python :: 3.13 and 3.14 classifiers.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Poem

🐇 Hop, hop, hooray for versions new,
Three-thirteen and three-fourteen in view!
Cython builds and workflows spin,
setup.py lets the new versions in.
The rabbit stamps each classifier bright—
More Pythons tested, everything's right! 🎉

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main objective of the changeset: adding build support for Python 3.13 and 3.14.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch build/python-3.14

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
.github/workflows/py313.yaml (1)

15-15: ⚖️ Poor tradeoff

Consider security hardening: pin actions and disable credential persistence.

For improved supply-chain security, consider:

  1. Pinning actions to commit SHAs instead of tags (e.g., actions/checkout@<sha>)
  2. Setting persist-credentials: false on the checkout step to prevent credential leakage
Example hardening
     steps:
-    - uses: actions/checkout@v4
+    - uses: actions/checkout@v4
+      with:
+        persist-credentials: false
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/py313.yaml at line 15, The checkout action in the workflow
is using a version tag (v4) instead of a pinned commit SHA, which poses a
security risk. Update the `uses: actions/checkout@v4` line to pin it to a
specific commit SHA (e.g., `actions/checkout@<full-commit-sha>`) for
supply-chain security. Additionally, add a `with:` section to the checkout step
and set `persist-credentials: false` to prevent credential leakage and improve
security posture.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/py313.yaml:
- Around line 22-26: Python 3.12+ removed setuptools from the standard library,
causing setup.py imports to fail. In `.github/workflows/py313.yaml` at line 26,
add setuptools to the pip install command alongside cython (change the line from
`python -m pip install cython` to `python -m pip install setuptools cython`).
Apply the same fix in `.github/workflows/py314.yaml` at line 26, adding
setuptools to that pip install command as well.

---

Nitpick comments:
In @.github/workflows/py313.yaml:
- Line 15: The checkout action in the workflow is using a version tag (v4)
instead of a pinned commit SHA, which poses a security risk. Update the `uses:
actions/checkout@v4` line to pin it to a specific commit SHA (e.g.,
`actions/checkout@<full-commit-sha>`) for supply-chain security. Additionally,
add a `with:` section to the checkout step and set `persist-credentials: false`
to prevent credential leakage and improve security posture.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2e0d3ea9-70c9-4513-ba9c-db0629eeedb1

📥 Commits

Reviewing files that changed from the base of the PR and between a86929e and 24f67d2.

📒 Files selected for processing (4)
  • .github/workflows/py313.yaml
  • .github/workflows/py314.yaml
  • build-linux-wheel.sh
  • setup.py

Comment thread .github/workflows/py313.yaml Outdated
@mejroslav
mejroslav requested a review from ateska June 15, 2026 11:59
@mejroslav
mejroslav merged commit 7db6630 into main Jun 15, 2026
8 checks passed
@mejroslav
mejroslav deleted the build/python-3.14 branch June 15, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants