Skip to content

Remove version dirtiness#583

Merged
byewokko merged 3 commits into
mainfrom
fix/remove-tag-dirtiness
Jun 25, 2026
Merged

Remove version dirtiness#583
byewokko merged 3 commits into
mainfrom
fix/remove-tag-dirtiness

Conversation

@byewokko

@byewokko byewokko commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Issue

The service manifest reports version with the -dirty suffix even when built from a clean-tagged revision.

Solution

Remove .dockerignore and update the Dockerfile to ensure the entire repo is copied in the builder stage.

Summary by CodeRabbit

  • Chores
    • Updated the container build process to copy the full project context before generating build metadata, improving image consistency.
    • Adjusted the Docker ignore rules so selected repository folders are included in the build context.

@byewokko byewokko self-assigned this Jun 25, 2026
@byewokko byewokko added the bug Something isn't working label Jun 25, 2026
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@byewokko, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 16 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e84b66b4-492d-4fce-a936-1a95f1a3ddc7

📥 Commits

Reviewing files that changed from the base of the PR and between 1028ebd and bbcfd81.

📒 Files selected for processing (1)
  • CHANGELOG.md
📝 Walkthrough

Walkthrough

The Docker build context is changed by clearing .dockerignore and updating the builder stage to copy the full repository before generating MANIFEST.json. The runtime stage and command are unchanged.

Changes

Docker build context update

Layer / File(s) Summary
Repository copy before manifest generation
Dockerfile, .dockerignore
.dockerignore is cleared, and the builder stage copies the full repository into /app/seacat-auth before running asab-manifest.py from that directory.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through the Docker den,
With a clean repo once again.
No dusty ignores in my nest,
Just full-context builds at their best.
Manifest done, ears up high,
And -dirty tags waved goodbye.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: fixing the version being marked dirty during Docker builds.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-tag-dirtiness

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@byewokko
byewokko merged commit 25938bd into main Jun 25, 2026
7 of 8 checks passed
@byewokko
byewokko deleted the fix/remove-tag-dirtiness branch June 25, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant