Skip to content

Fix: Ensure LDAP script always includes memberOf attr; Improve logging#588

Merged
byewokko merged 4 commits into
mainfrom
fix/ldap-script-missing-memberof
Jul 15, 2026
Merged

Fix: Ensure LDAP script always includes memberOf attr; Improve logging#588
byewokko merged 4 commits into
mainfrom
fix/ldap-script-missing-memberof

Conversation

@byewokko

@byewokko byewokko commented Jul 14, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Improve LDAP synchronization so group membership information is consistently available by ensuring the memberOf attribute is always included in the queried attributes even if not present in config.
  • Improve logging.

@byewokko byewokko self-assigned this Jul 14, 2026
@byewokko byewokko added the bug Something isn't working label Jul 14, 2026
@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

LDAP configuration now always includes memberOf in the parsed attribute list. The synchronization loop receives an additional blank line, and the changelog records the v26.15-alpha13 release and LDAP fix.

Changes

LDAP synchronization

Layer / File(s) Summary
LDAP attribute handling and release notes
scripts/ldap-access-sync.py, CHANGELOG.md
load_ldap_config ensures memberOf is present, main() receives a formatting-only blank line, and the changelog documents the corresponding release and fix.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested labels: bug

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly reflects the main fix to always include memberOf, and the extra logging note is secondary.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ldap-script-missing-memberof

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@byewokko byewokko changed the title Fix: Ensure LDAP script always includes memberOf attr Fix: Ensure LDAP script always includes memberOf attr; Improve logging Jul 15, 2026
@byewokko
byewokko merged commit e8d8919 into main Jul 15, 2026
8 checks passed
@byewokko
byewokko deleted the fix/ldap-script-missing-memberof branch July 15, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant