perf(control): finish streaming and virtualization overhaul#456
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e8cbb30. Configure here.
| command: 'bun dev --port 3099', | ||
| url: 'http://localhost:3099', | ||
| command: `bunx next dev --port ${port}`, | ||
| url: baseURL, |
There was a problem hiding this comment.
Playwright port/baseURL mismatch when only one env var set
Medium Severity
When PLAYWRIGHT_BASE_URL is set without PLAYWRIGHT_PORT (e.g. PLAYWRIGHT_BASE_URL=http://localhost:3001), port defaults to '3099', so webServer.command starts Next on 3099 while webServer.url polls 3001. The test run will hang waiting for a server that never appears on the expected port. Deriving port from the URL, or requiring both vars together, would fix this.
Reviewed by Cursor Bugbot for commit e8cbb30. Configure here.


Summary
Local validation
Deploy / iOS smoke
Note
Medium Risk
Medium risk because it changes the
/controlstreaming transport contract (adds WebSocket + negotiatedtext_op) and introduces new client-side execution paths (virtualized lists and a Web Worker) that could affect real-time rendering and history replay behavior.Overview
Completes the remaining
/controlperf overhaul items by virtualizing the transcript/thoughts UI (via@tanstack/react-virtual) and offloading large history replays to a newevents-worker.tsWeb Worker with a synchronous fallback.Updates the streaming contract documentation to include a WebSocket transport (
/api/control/ws) and capability-negotiatedtext_opdeltas plus finalized canonical assistant rows, and refreshes the perf log/measurements and local validation commands.Adds perf regression coverage by introducing an
@perfPlaywright test (control-perf.spec.ts) that loads a large fixture mission and asserts DOM/heap/longtask budgets, and makes Playwright’sbaseURL/port configurable via env vars.Reviewed by Cursor Bugbot for commit e8cbb30. Bugbot is set up for automated code reviews on this repo. Configure here.