[codex] Preserve valid PyCharm sibling SDKs#766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uv (...)PyCharm SDKs whose interpreter paths still exist, even when they are not part of the active checkout keep list.uv (...)SDK entries whose interpreter path is missing.uv (agilab-src)while removing a stale checkout SDK.Repro
Run
pycharm/setup_pycharm.pyfrom one AGILAB checkout, then from a sibling checkout such as/Users/agi/agilab-src. The second run can remove the first checkout's valid SDK entry from JetBrainsjdk.table.xml, leaving that project XML pointing at an SDK name PyCharm no longer knows.Root Cause
JdkTable.prune_uv_names()removed everyuv (...)SDK not in the active checkout's generated keep list. That was too aggressive for machines with multiple valid AGILAB source checkouts.Regression Test
test_prune_uv_names_keeps_valid_sibling_checkout_sdks_and_removes_staleproves a valid sibling checkout SDK is retained while a missing-interpreter SDK is pruned.Validation
uv --preview-features extra-build-dependencies run python tools/impact_validate.py --files pycharm/setup_pycharm.py test/test_setup_pycharm.pyuv --preview-features extra-build-dependencies run pytest -q -o addopts='' test/test_setup_pycharm.pyReview Evidence
Not used.
Agent Metadata
/fastmode: unknown