[codex] Fix PyCharm core test run configs#767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix three tracked PyCharm core pytest run configurations that were bound to the
uv (agi-cluster)SDK but had an empty working directory. The generated CLI wrappers were regenerated so the shell launchers now run from the samesrc/agilab/core/agi-clusterdirectory.Repro
PyCharm
test base_worker,test dag_worker, andtest work_dispatcherlaunched with an emptyWORKING_DIRECTORY, unlike the sibling core pytest configs for pandas, polars, and distributor tests.Root Cause
The affected tracked run configurations did not set the agi-cluster project working directory, so PyCharm could resolve the test target with the right SDK but run from the wrong/default directory.
Regression Test
test/test_setup_pycharm.py::test_tracked_run_configs_use_valid_uv_sdk_bindingsnow rejects agi-cluster pytest configs targetingsrc/agilab/core/test/unless their working directory is$PROJECT_DIR$/src/agilab/core/agi-cluster.Validation
uv --preview-features extra-build-dependencies run python tools/generate_runconfig_scripts.pyuv --preview-features extra-build-dependencies run pytest -q -o addopts='' test/test_setup_pycharm.py::test_tracked_run_configs_use_valid_uv_sdk_bindingsuv --preview-features extra-build-dependencies run python tools/impact_validate.py --stageduv --preview-features extra-build-dependencies run pytest -q -o addopts='' test/test_setup_pycharm.pyReview Evidence
Not used.
Agent Metadata
tokki 1.0.19/fastmode: no