Target refactor: simplify codebase structures and optimize risk parsing performance

[lalit-t0251068]

refactor: simplify codebase structures and optimize risk parsing performance

📝 Overview

This pull request introduces a comprehensive series of codebase simplifications and performance optimizations across 6 core files within the lib module. These improvements focus on removing redundant wrappers, simplifying complex syntactic patterns (such as immediately-invoked anonymous functions and nested ternaries), and resolving a high-impact $O(N \times M)$ parsing loop bottleneck.

All changes strictly preserve existing functional behavior and public API contracts, verified by 100% success of the local test suite.

---

🚀 Key Improvements & Performance Impact

1. Risk Parsing Optimization ($O(N \times M) \rightarrow O(1)$ lookup)

• File: lib/src/api/xml-json/alter-isra/alter-risks.js
• Issue: Inside the per-risk .forEach loop, the lookup maps businessAssets and supportingAssets were completely rebuilt from scratch on every single iteration from static input arrays. This was a classic performance hotspot for large SRA/XML datasets.
• Refactor: Moved the map constructions outside of the loop. They are now built exactly once and can be retrieved in $O(1)$ constant time inside the loop, significantly reducing CPU cycles and garbage collection overhead.

2. Spelling Corrections Streamlining (Chained .replace)

• File: lib/src/api/xml-json/parser.js
• Issue: The editName helper function relied on five separate, chained .match() checks paired with ternary expressions to sanitize XML tags.
• Refactor: Chained .replace operations directly. Since String.prototype.replace natively returns the original string unchanged if there is no match, this removes the redundant conditional checks and matches, improving both speed and readability.

3. Redundant Closure & IIFE Removals

• Files: lib/src/utility-global.js & lib/src/api/xml-json/alter-isra/alter-isra.js
• Refactor:
  • Simplified utility-global.js from a nested Immediately Invoked Function Expression (IIFE) with warning suppressions (no-unused-vars) into a standard CommonJS module directly exporting a clean counter closure.
  • Removed a redundant self-invoking function wrapper (israJSONDataCopy, xmlDataCopy) => { ... })(israJSONData, xmlData) inside alterISRA and executed the logic directly in the parent scope.

4. Code Clarity & Syntax Flattening

• Files: lib/src/api/xml-json/alter-isra/alter-business-assets.js & lib/src/api/xml-json/populate-class.js
• Refactor:
  • Replaced a highly convoluted immediately-invoked destructuring function (({ props }) => ({ props }))(ba) with standard ES6 destructuring and object assignment for ba.businessAssetProperties.
  • Flattened redundant ternary checks like highestBAId? highestBAId: businessAssetId where the variable is guaranteed to be a truthy pre-incremented number.

---

🛠️ Verification & Test Coverage

All modifications have been validated locally using Jest:

• Test Suites: 19 passed, 19 total
• Tests: 311 passed, 311 total
• Behavior: 0 regressions introduced. External API inputs, schema validations, and file serialization formats remain 100% compatible.

---

📁 Files Modified

File Path	Description of Refactor
lib/src/utility-global.js	Removed IIFE, clean CommonJS counter closure export.
lib/src/api/xml-json/parser.js	Direct chaining of .replace in editName.
lib/src/api/xml-json/alter-isra/alter-business-assets.js	Clean ES6 object destructuring in businessAssetProperties.
lib/src/api/xml-json/alter-isra/alter-isra.js	Redundant parameter-repassing IIFE wrapper removed.
lib/src/api/xml-json/alter-isra/alter-risks.js	Optimized lookup maps extraction out of loop.
lib/src/api/xml-json/populate-class.js	Removed redundant ternary assertions.
SIMPLIFICATION_PLAN.md	Detailed analysis document compiled for review.