Add Wi-Fi connectivity live activity#1305
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e1b383a5e4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var preferredNotificationWidth: CGFloat { | ||
| textWidth + 76 + 16 | ||
| } |
There was a problem hiding this comment.
Include the notch spacer in the network chin width
When the network activity is shown, ContentView uses preferredNotificationWidth as the full chin width, but BoringNetworkActivityView also renders a center spacer of vm.closedNotchSize.width + 10 between the text and icon. On the default non-notch width this makes the rendered activity roughly textWidth + 195 + 76, while the chin is only textWidth + 76 + 16, so with hideTitleBar enabled the lower chin area is substantially narrower than the visible activity and leaves the right side without the expected black fill/hit area. Include the center spacer in this width calculation or compute the width where closedNotchSize is available.
Useful? React with 👍 / 👎.
Summary
Add a small Wi-Fi connectivity live activity that appears when the Wi-Fi path connects or disconnects.
What changed
NWPathMonitorservice for Wi-Fi path changesNetworkStatusViewModelthat suppresses startup noise and only triggers on real state changesValidation
xcodebuild -scheme boringNotch -project boringNotch.xcodeproj -configuration Debug build CODE_SIGNING_ALLOWED=NO