Skip to content

Add Wi-Fi connectivity live activity#1305

Open
TheBestVivBoy wants to merge 4 commits into
TheBoredTeam:devfrom
TheBestVivBoy:vivan/network-live-activity
Open

Add Wi-Fi connectivity live activity#1305
TheBestVivBoy wants to merge 4 commits into
TheBoredTeam:devfrom
TheBestVivBoy:vivan/network-live-activity

Conversation

@TheBestVivBoy

@TheBestVivBoy TheBestVivBoy commented Jun 5, 2026

Copy link
Copy Markdown

Summary

Add a small Wi-Fi connectivity live activity that appears when the Wi-Fi path connects or disconnects.

What changed

  • added a lightweight NWPathMonitor service for Wi-Fi path changes
  • added a NetworkStatusViewModel that suppresses startup noise and only triggers on real state changes
  • added a compact closed-notch network activity view
  • matched the notification spacing to the existing battery/charging activity so the text block and icon sit in the same visual zones

Validation

  • built with xcodebuild -scheme boringNotch -project boringNotch.xcodeproj -configuration Debug build CODE_SIGNING_ALLOWED=NO

@TheBestVivBoy TheBestVivBoy marked this pull request as ready for review June 5, 2026 00:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1b383a5e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +54 to +56
var preferredNotificationWidth: CGFloat {
textWidth + 76 + 16
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Include the notch spacer in the network chin width

When the network activity is shown, ContentView uses preferredNotificationWidth as the full chin width, but BoringNetworkActivityView also renders a center spacer of vm.closedNotchSize.width + 10 between the text and icon. On the default non-notch width this makes the rendered activity roughly textWidth + 195 + 76, while the chin is only textWidth + 76 + 16, so with hideTitleBar enabled the lower chin area is substantially narrower than the visible activity and leaves the right side without the expected black fill/hit area. Include the center spacer in this width calculation or compute the width where closedNotchSize is available.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant